From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andre Heider Date: Wed, 26 Aug 2020 09:12:36 +0200 Subject: [PATCH u-boot-marvell] arm64: dts: armada-3720-espressobin: fix COMPHY nodes In-Reply-To: <20200819095725.17574-1-marek.behun@nic.cz> References: <20200819095725.17574-1-marek.behun@nic.cz> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 19/08/2020 11:57, Marek Beh?n wrote: > This commit fixes initialization of COMPHY on EspressoBin. > > Commit 22f418935be4 ("phy: marvell: a3700: Use comphy_mux on Armada > 37xx.") introduced usage of comphy_mux on Armada 37xx comphy driver. > The lanes are defined in comphy_a3700.c as described in functional > specification, that is: > lane 0 is SGMII1 or USB3 > lane 1 is PCIe or SGMII0 > lane 2 is SATA or USB3 > > But the DTS for EspressoBin configures PCIe on lane 0 and USB3 on > lane 1, which is wrong in the sense of the specification and doesn't > work with the comphy_mux code, which is 2 years now (the aardvark driver > causes synchronous abort in U-Boot). > > It worked till the above mentioned commit, because the code for powering > up PCIe PHY doesn't work with lane number at all, and the code for > powering up USB3 PHY works differently only if USB3 is on lane 2, ie. > the check goes like: > if (lane == 2) > something > else > something else > so it does not differentiate between lanes 0 and 1. > > In the future I shall post patches that remove the comphy_a3700 driver > and add comphy driver which uses calls to ATF, like Linux' driver does. > This will have the advantage of same DTS bindings as Linux', but till > this is done, we need this patch. > > Signed-off-by: Marek Beh?n > Tested-by: Pali Roh?r > Cc: Stefan Roese Tested-by: Andre Heider Nice, thank you! I remember getting these data aborts more than a year ago... Andre