From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51F51C001DF for ; Thu, 3 Aug 2023 10:30:08 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4E4EF86CA9; Thu, 3 Aug 2023 12:29:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="S3IqQr7n"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 570EC86847; Thu, 3 Aug 2023 11:20:54 +0200 (CEST) Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EFEE98680E for ; Thu, 3 Aug 2023 11:20:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=prvs=65790efe27=etienne.carriere@foss.st.com Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 3738p727031203; Thu, 3 Aug 2023 11:20:47 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= from:to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; s= selector1; bh=ZXvagHsWn82v7/EstcnjE9WgU3wXx47x5pkguEOgZ+A=; b=S3 IqQr7nSrwZWNzAFOFbMv02YdYADciq5vH0Dgc1T9Xoyq7+YCfhRg8HbsrFhmyBe8 3x4PHXGV7VPjjB7sn5WiDfYYSNcoyww1rXzkRBwvN/fL4Tq6flH6rbAX1W1BhTEu s5RHQBuhxco4B694SNVTgpf3Z9V0qwtyh/KaqDrkPSrLkvX2Sqh2TEFOyMhle5en Gs1ggZfdE+KWUFPwP7UegbDP3wp8mMDJcYzfY505Gv2v53MuuP50MgkgBnQQ2u7L c/mmxTvvQq866Ehrp/rDyKDEEWo6sLpf65Dnm+QevcTz48VQLEaT8Ssr2OXRWqH7 kQymi5hdaXuWgyXDxivg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3s893bg6ry-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Aug 2023 11:20:47 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 538D7100089; Thu, 3 Aug 2023 11:20:46 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 4D4E0216EF6; Thu, 3 Aug 2023 11:20:46 +0200 (CEST) Received: from SHFDAG1NODE1.st.com (10.75.129.69) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 3 Aug 2023 11:20:46 +0200 Received: from SHFDAG1NODE1.st.com ([fe80::b848:dbeb:cd0:84a0]) by SHFDAG1NODE1.st.com ([fe80::b848:dbeb:cd0:84a0%14]) with mapi id 15.01.2507.021; Thu, 3 Aug 2023 11:20:45 +0200 From: Etienne CARRIERE - foss To: Simon Glass , AKASHI Takahiro CC: "trini@konsulko.com" , Etienne CARRIERE , "u-boot@lists.denx.de" Subject: Re: [PATCH v2 01/12] scmi: refactor the code to hide a channel from devices Thread-Topic: [PATCH v2 01/12] scmi: refactor the code to hide a channel from devices Thread-Index: AQHZv+CyrnSGe00v2kqPBHCHA1F9zK/Mp1mAgAuuOpc= Date: Thu, 3 Aug 2023 09:20:45 +0000 Message-ID: References: <20230726083808.140780-1-takahiro.akashi@linaro.org> <20230726083808.140780-2-takahiro.akashi@linaro.org>, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.201.20.20] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-03_07,2023-08-01_01,2023-05-22_02 X-Mailman-Approved-At: Thu, 03 Aug 2023 12:29:43 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hello Takahiro-san, > From: U-Boot on behalf of Simon Glass > Sent: Thursday, July 27, 2023 2:50 AM >=20 > On Wed, 26 Jul 2023 at 02:38, AKASHI Takahiro > wrote: > > > > The commit 85dc58289238 ("firmware: scmi: prepare uclass to pass channe= l > > reference") added an explicit parameter, channel, but it seems to make > > the code complex. > > > > Hiding this parameter will allow for adding a generic (protocol-agnosti= c) > > helper function, i.e. for PROTOCOL_VERSION, in a later patch. > > > > Signed-off-by: AKASHI Takahiro > > --- > > v2 > > * new patch > > --- > > drivers/clk/clk_scmi.c | 27 ++------- > > drivers/firmware/scmi/scmi_agent-uclass.c | 74 ++++++++++++++++++----- > > drivers/power/regulator/scmi_regulator.c | 27 +++------ > > drivers/reset/reset-scmi.c | 19 +----- > > include/scmi_agent.h | 15 +++-- > > 5 files changed, 86 insertions(+), 76 deletions(-) > > >=20 > Reviewed-by: Simon Glass Sorry for this late feedback. I initially saw no issues with this patch ser= ies but testing the series against stm32mp135f-dk board which is using SCMI resources, I saw the board failed to boot. The issue is related to udevice parent tree and common clock framework. I'll post comments on patch 01/12. Best regards, Etienne=