Re: [PATCH 05/13] configs: am68: Add configs for enabling Ethboot in R5SPL

[Roger Quadros <rogerq@kernel.org>]

On 09/01/2025 10:43, Vankar, Chintan wrote:
> 
> 
> On 1/7/2025 8:08 PM, Roger Quadros wrote:
>>
>>
>> On 07/01/2025 11:38, Chintan Vankar wrote:
>>> Add configs for enabling Ethernet boot in R5SPL.
>>>
>>> Signed-off-by: Chintan Vankar <c-vankar@ti.com>
>>> ---
>>>   configs/am68_sk_r5_ethboot_defconfig | 80 ++++++++++++++++++++++++++++
>>>   1 file changed, 80 insertions(+)
>>>   create mode 100644 configs/am68_sk_r5_ethboot_defconfig
>>>
>>> diff --git a/configs/am68_sk_r5_ethboot_defconfig b/configs/am68_sk_r5_ethboot_defconfig
>>> new file mode 100644
>>> index 00000000000..9bfbb5a3bfe
>>> --- /dev/null
>>> +++ b/configs/am68_sk_r5_ethboot_defconfig
>>> @@ -0,0 +1,80 @@
>>> +#include <configs/am68_sk_r5_defconfig>
>>> +
>>> +CONFIG_ARM=y
>>> +CONFIG_ARCH_K3=y
>>> +CONFIG_SOC_K3_J721S2=y
>>> +CONFIG_TARGET_J721S2_R5_EVM=y
>>> +CONFIG_DEFAULT_DEVICE_TREE="k3-am68-sk-r5-base-board"
>>
>> Please don't add duplicates that are already included in configs/am68_sk_r5_defconfig
>> or configs/j721s2_evm_r5_defconfig
>>
> 
> Hello Roger, These config options are required despite of they are
> present in the file that is being included for buildman to work, you can
> refer to Tom's comment at here:
> https://lore.kernel.org/r/20240705153721.GF38804@bill-the-cat/
> after which I included the same while posting config file for AM62x-SK.
> 

Understood. Thanks!

>>> +CONFIG_SPL_GPIO=y
>>> +CONFIG_SPL_BOARD_INIT=y
>>> +CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x200000
>>> +CONFIG_SPL_DMA=y
>>> +CONFIG_SPL_ENV_SUPPORT=y
>>> +CONFIG_SPL_ETH=y
>>> +CONFIG_SPL_I2C=y
>>> +CONFIG_SPL_NET=y
>>> +CONFIG_SPL_NET_VCI_STRING="AM68 U-Boot R5 SPL"
>>> +CONFIG_CMD_DHCP=y
>>> +CONFIG_SPL_SYSCON=y
>>> +CONFIG_DMA_CHANNELS=y
>>> +CONFIG_TI_K3_NAVSS_UDMA=y
>>> +CONFIG_DM_I2C=y
>>> +CONFIG_PHY_TI_DP83867=y
>>> +CONFIG_TI_AM65_CPSW_NUSS=y
>>> +CONFIG_SPI=n
>>> +CONFIG_SPL_SPI=n
>>> +CONFIG_DM_SPI=n
>>> +CONFIG_SPL_DM_SPI=n
>>> +CONFIG_SPL_SYS_MALLOC=y
>>> +CONFIG_SPI_MEM=n
>>> +CONFIG_CMD_FAT=n
>>> +CONFIG_FS_FAT=n
>>> +CONFIG_SPL_FS_FAT=n
>>> +CONFIG_MMC_SDHCI=n
>>> +CONFIG_MTD=n
>>> +CONFIG_CMD_FAT=n
>>
>> Please explain in commit log why you are setting many of the
>> options to "n". Is it due to memory limitation?
>>
> 
> Yes, that is because of memory limitation, we have faced the same
> limitation while working with AM62x Ethernet boot.
> 
>>> +CONFIG_SYS_RELOC_GD_ENV_ADD=y
>>> +CONFIG_SPL_DM_SPI_FLASH=n
>>> +CONFIG_SPL_HAS_CUSTOM_MALLOC_START=n
>>> +CONFIG_HUSH_PARSER=n
>>> +CONFIG_CMD_DFU=n
>>> +CONFIG_CMD_GPT=n
>>> +CONFIG_SPL_YMODEM_SUPPORT=n
>>> +CONFIG_ARCH_FIXUP_FDT_MEMORY=n
>>> +CONFIG_SPL_ENV_IS_NOWHERE=y
>>> +CONFIG_DM_EVENT=y
>>> +CONFIG_INPUT=n
>>> +CONFIG_ESM_K3=y
>>> +CONFIG_SPL_LOAD_BLOCK=y
>>> +CONFIG_DFU=n
>>> +CONFIG_SPL_DFU=n
>>> +CONFIG_TI_I2C_BOARD_DETECT=y
>>> +CONFIG_K3_EARLY_CONS=n
>>> +CONFIG_K3_QOS=n
>>> +CONFIG_USE_BOOTCOMMAND=n
>>> +CONFIG_SPL_MTD=n
>>> +CONFIG_SPL_NAND_SPI_SUPPORT=n
>>> +CONFIG_BOOTDEV_ETH=y
>>> +CONFIG_USB=n
>>> +CONFIG_FS_LOADER=n
>>> +CONFIG_SPL_FS_LOADER=n
>>> +CONFIG_SPL_DM_SPI=y
>>> +CONFIG_PINCTRL_GENERIC=n
>>> +CONFIG_PINMUX=n
>>> +CONFIG_SPL_PINCTRL_GENERIC=n
>>> +CONFIG_SPL_PINMUX=n
>>> +CONFIG_DM_REGULATOR=n
>>> +CONFIG_TI_SCI_POWER_DOMAIN=n
>>> +CONFIG_CMD_REMOTEPROC=y
>>> +CONFIG_SYSRESET=n
>>> +CONFIG_LAST_STAGE_INIT=y
>>> +CONFIG_OF_UPSTREAM=n
>>
>> Why no OF_UPSTREAM?
>>
> 
> Device tree files are not in-sync with upstream linux for AM68, getting
> compile time errors for the same, that's the reason I have disabled this
> config option.

I suggest to do a sync and not disable CONFIG_OF_UPSTREAM.

> 
>>> +CONFIG_K3_DM_FW=y
>>> +CONFIG_SPL_SPI_LOAD=n
>>> +CONFIG_SPL_DM_SPI=n
>>> +CONFIG_NOR_SUPPORT=n
>>> +CONFIG_SPL_NOR_SUPPORT=n
>>> +CONFIG_SPL_DM_SPI=n
>>> +CONFIG_SYS_MALLOC_CLEAR_ON_INIT=n
>>> +CONFIG_SPL_SYS_MALLOC_CLEAR_ON_INIT=n
>>> +CONFIG_BOOTDEV_ETH=n
>>

-- 
cheers,
-roger