public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH] mvebu: bubt: Drop dead code
Date: Thu, 6 Aug 2020 14:08:51 +0200	[thread overview]
Message-ID: <b38be04b-19e1-868d-b0e1-4e76e0798a8d@denx.de> (raw)
In-Reply-To: <20200724211317.2678-1-trini@konsulko.com>

On 24.07.20 23:13, Tom Rini wrote:
> The code around CONFIG_SYS_MMC_ENV_PART has been untested since merge.
> This can be seen by it referencing 'mmc->part_num' which was migrated
> elsewhere prior to this code being merged.
> 
> Cc: Joel Johnson <mrjoel@lixil.net>
> Cc: Stefan Roese <sr@denx.de>
> Signed-off-by: Tom Rini <trini@konsulko.com>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   cmd/mvebu/bubt.c | 15 ---------------
>   1 file changed, 15 deletions(-)
> 
> diff --git a/cmd/mvebu/bubt.c b/cmd/mvebu/bubt.c
> index a27b0df8ae78..85ae588676fe 100644
> --- a/cmd/mvebu/bubt.c
> +++ b/cmd/mvebu/bubt.c
> @@ -176,16 +176,6 @@ static int mmc_burn_image(size_t image_size)
>   		return err;
>   	}
>   
> -#ifdef CONFIG_SYS_MMC_ENV_PART
> -	if (mmc->part_num != CONFIG_SYS_MMC_ENV_PART) {
> -		err = mmc_switch_part(mmc_dev_num, CONFIG_SYS_MMC_ENV_PART);
> -		if (err) {
> -			printf("MMC partition switch failed\n");
> -			return err;
> -		}
> -	}
> -#endif
> -
>   	/* SD reserves LBA-0 for MBR and boots from LBA-1,
>   	 * MMC/eMMC boots from LBA-0
>   	 */
> @@ -217,11 +207,6 @@ static int mmc_burn_image(size_t image_size)
>   	}
>   	printf("Done!\n");
>   
> -#ifdef CONFIG_SYS_MMC_ENV_PART
> -	if (mmc->part_num != CONFIG_SYS_MMC_ENV_PART)
> -		mmc_switch_part(mmc_dev_num, mmc->part_num);
> -#endif
> -
>   	return 0;
>   }
>   
> 


Viele Gr??e,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de

  parent reply	other threads:[~2020-08-06 12:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24 21:13 [PATCH] mvebu: bubt: Drop dead code Tom Rini
2020-07-25 11:38 ` Stefan Roese
2020-07-25 12:59   ` Tom Rini
2020-07-30  6:50     ` Stefan Roese
2020-08-06 12:08 ` Stefan Roese [this message]
2020-08-06 14:27   ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b38be04b-19e1-868d-b0e1-4e76e0798a8d@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox