From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 316CFC433F5 for ; Sat, 30 Apr 2022 18:44:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E025A83F4C; Sat, 30 Apr 2022 20:44:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="EpU+egAY"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 31CDC83F52; Sat, 30 Apr 2022 20:44:25 +0200 (CEST) Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C694E83F4A for ; Sat, 30 Apr 2022 20:44:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jbx6244@gmail.com Received: by mail-ej1-x62c.google.com with SMTP id k23so21067874ejd.3 for ; Sat, 30 Apr 2022 11:44:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=utkcTgz0R7EPxPKoJgNNR8cb0TLEdo6r+gc+/vx9h60=; b=EpU+egAYPl7fdjXapUs9Ro4fjjpO8vpQgB2r178y3qeu2tP+EkociRabfPw5lU9hy8 EjBDRsDwcw+XxGSYaMmX6BISfyCZXkUyeienC08fH3ExpNmqB0Lxr5HCLsEsKFHmwlzv RrhOezA1blSpP3nQ81gDyGRhPDMXdyEw7MQ0HDp8ilVjR1zaFzTvms301qV8vODL/U8j 79Opk5+mhm/yKFFF2cLTahO2kdSui/eXrbBixvJGiLu56G2T0Kl+qOLJgSzqQo2V4jkc qkfSde6NkNuARVtyB8YiA+jXrW0BWIbs2HgyWNN2Th4ThOaBNQjO05Q96mLwmYT8gr+I koTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=utkcTgz0R7EPxPKoJgNNR8cb0TLEdo6r+gc+/vx9h60=; b=F7u3jT4Nlhcv7mcO38C4hVskGRUcgwfS8mqmZq/N5pfq/E2IV6DBRKEtgyyNZpUTXF 6GPEmnxnsJVK3ivps2A1dMVKaD07R/zukaGMX5cTRGQVMiPBMw+ANfbpDs7t9F7H10qr mSYVL792tY0ofqQrZY2KevVpnRwUHwcaRR1lXeIyL4aDDDwEwMQAGrzV4Puf7MiKPYOS pPnPe0KZ77MAr376r3p7RAHieFMAkHkBmYXp/dyZ52KcQA/FUpZqaKnBy2JA1fGG2LrS vksxu0CXG6fM/Imnzj9IWPXcEVrBfjaCUa/Vrq4UJvJr5RPWRkecJPok86UffIJUZLlY ChnA== X-Gm-Message-State: AOAM532IbNYavT6WKdgyq3Kz9NGNrIcXTYjZLWSCmqg8pYZ1HYzJ40cD bSfx39SHuJx0OvcOowA8d1s= X-Google-Smtp-Source: ABdhPJwCj/No8fHQ6Av4d4WZO4BaYnJUSZInaEzhwDoARxnb3MsgeccCQzZSvDr4sUwvDaJe6XSjmQ== X-Received: by 2002:a17:906:d54b:b0:6e7:f185:18d5 with SMTP id cr11-20020a170906d54b00b006e7f18518d5mr5057777ejc.155.1651344262361; Sat, 30 Apr 2022 11:44:22 -0700 (PDT) Received: from [192.168.2.1] (81-204-249-205.fixed.kpn.net. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id bf16-20020a0564021a5000b0042617ba63aesm4487212edb.56.2022.04.30.11.44.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Apr 2022 11:44:21 -0700 (PDT) Message-ID: Date: Sat, 30 Apr 2022 20:44:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v5 07/12] efi_loader: disk: a helper function to create efi_disk objects from udevice Content-Language: en-US To: AKASHI Takahiro , xypron.glpk@gmx.de, sjg@chromium.org, ilias.apalodimas@linaro.org Cc: masami.hiramatsu@linaro.org, U-Boot-Denx References: <20220419010517.47175-1-takahiro.akashi@linaro.org> <20220419010517.47175-8-takahiro.akashi@linaro.org> From: Johan Jonker In-Reply-To: <20220419010517.47175-8-takahiro.akashi@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 4/19/22 03:05, AKASHI Takahiro wrote: > > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig > index bc518d7a413b..6b245f50a726 100644 > --- a/lib/efi_loader/Kconfig > +++ b/lib/efi_loader/Kconfig > @@ -14,6 +14,8 @@ config EFI_LOADER > depends on DM_ETH || !NET > depends on !EFI_APP > default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8 > + select DM_EVENT > + select EVENT_DYNAMIC Hi, The use of this select without EVENT leads to this warning: WARNING: unmet direct dependencies detected for EVENT_DYNAMIC Depends on [n]: EVENT [=n] Selected by [y]: - EFI_LOADER [=y] && OF_LIBFDT [=y] && (ARM [=y] && (SYS_CPU [=armv7]=arm1136 || SYS_CPU [=armv7]=arm1176 || SYS_CPU [=armv7]=armv7 || SYS_CPU [=armv7]=armv8) || X86 [=n] || RISCV [=n] || SANDBOX [=n]) && (!EFI_STUB [=n] || !X86_64 [=n] || EFI_STUB_64BIT [=n]) && (!EFI_STUB [=n] || !X86 [=n] || X86_64 [=n] || EFI_STUB_32BIT [=n]) && BLK [=y] && (DM_ETH [=n] || !NET [=n]) && !EFI_APP [=n] Previously there was no need for events on rk3066. Is that normal behavior or should we include "select EVENT" here as well? Johan > select LIB_UUID > imply PARTITION_UUIDS > select HAVE_BLOCK_DEVICE > @@ -40,6 +42,7 @@ config CMD_BOOTEFI_BOOTMGR > > config EFI_SETUP_EARLY > bool > + default y > > choice > prompt "Store for non-volatile UEFI variables"