From: Fabio Estevam <festevam@denx.de>
To: Johannes Schneider <johannes.schneider@leica-geosystems.com>
Cc: u-boot@lists.denx.de, peng.fan@oss.nxp.com, sbabic@denx.de,
trini@konsulko.com, bsp-development.geo@leica-geosystems.com,
"Peng Fan" <peng.fan@nxp.com>, "Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH v4 1/2] serial: mxc: enable the RX pipeline
Date: Tue, 06 Sep 2022 09:10:34 -0300 [thread overview]
Message-ID: <b47c2bb147cc1b8a65496d4d9cfc33fb@denx.de> (raw)
In-Reply-To: <20220906120645.1528646-2-johannes.schneider@leica-geosystems.com>
Hi Johannes,
On 06/09/2022 09:06, Johannes Schneider wrote:
> +
> + /* setting the baudrate triggers a reset, returning cr3 to its
> + * reset value but UCR3_RXDMUXSEL "should always be set."
> + * according to the imx8 reference-manual
> + */
> + writel(readl(&base->cr3) | UCR3_RXDMUXSEL, &base->cr3);
> +
Nitpick: the recommended style for multi-line comments is:
/*
* Setting the baudrate triggers a reset, returning cr3 to its
* reset value but UCR3_RXDMUXSEL "should always be set."
* according to the imx8 reference-manual.
*/
Reviewed-by: Fabio Estevam <festevam@denx.de>
next prev parent reply other threads:[~2022-09-06 12:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 12:06 [PATCH v4 0/2] serial_mxc: fixing reception Johannes Schneider
2022-09-06 12:06 ` [PATCH v4 1/2] serial: mxc: enable the RX pipeline Johannes Schneider
2022-09-06 12:10 ` Fabio Estevam [this message]
2022-09-06 12:06 ` [PATCH v4 2/2] serial: mxc: have putc use the TXFIFO Johannes Schneider
2022-09-06 12:10 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b47c2bb147cc1b8a65496d4d9cfc33fb@denx.de \
--to=festevam@denx.de \
--cc=bsp-development.geo@leica-geosystems.com \
--cc=johannes.schneider@leica-geosystems.com \
--cc=pali@kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=sbabic@denx.de \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox