From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E040CECAAD5 for ; Tue, 6 Sep 2022 12:10:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 96D83849DC; Tue, 6 Sep 2022 14:10:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1662466236; bh=m2RBMcSz+uyvFYpoY/WWyJujNQkpB0SkJRyj8k4eaio=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=rh/L8HDDtBE/m90NhBEcuk/aj36+yACmSdoRkIGspkIlcECBNsnOesvG8Ph0yVcmR gMN3KfjX5gpGhWaRR6VhXzgQcPbOwaAv3KS/vm+RC+rUlOChJ/VsMAxKKqpIvNWBTj hnlRQTTBEUU6gT+2BVCT9g5r/a9jvrJnNqV0YVlPA12QhWXQNjkCNWdKLZSwm0DO3r a7VB2EefzyTJLkzRHgV9Qt13WiLR1Px8rMRZLLddRORgPKZl9u6EAoCs4YCJTtqxJx CfS86FUa8gxV3HKvf5Fc/Kimh3np8jX3/FqIm0LjNzk2hkH4q2awhAzLoSCJK0CCKa YFvQH52r+ohUQ== Received: from mail.denx.de (unknown [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: festevam@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id C549D849D9; Tue, 6 Sep 2022 14:10:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1662466234; bh=m2RBMcSz+uyvFYpoY/WWyJujNQkpB0SkJRyj8k4eaio=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ykS55c5RgSFDAYnEz11dikgdi7hbl/mpNttmketUr/kirkJK0RKVSi7nF4HKZMgnq BENOJSGv1kGDZ211f4BPDZ8RnCKdEtQ7Byd6MTbVqNZicueaw75YepxidGFq10cymx aepwLmf78FhqVR3zj/JeYwdwEi+jwgIbCBsvZ3JRwF1o4JWwXJ7VzlnzlxKERuzuT9 0B6RuBhPssu2ITuZmhK/1SfZCo1QXrmAeoPJ92J5xX4hSzCxcaQc5Ow3b7hwaOvB+S KOjQAAa/oV36jdTOhRtjFbRn4VShg+XOep8peb5lsXMsiSZmgWAvSUGpPYCQ6qB52o XAtMXQq932FkQ== MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 06 Sep 2022 09:10:34 -0300 From: Fabio Estevam To: Johannes Schneider Cc: u-boot@lists.denx.de, peng.fan@oss.nxp.com, sbabic@denx.de, trini@konsulko.com, bsp-development.geo@leica-geosystems.com, Peng Fan , =?UTF-8?Q?Pali_Roh=C3=A1r?= Subject: Re: [PATCH v4 1/2] serial: mxc: enable the RX pipeline In-Reply-To: <20220906120645.1528646-2-johannes.schneider@leica-geosystems.com> References: <20220906120645.1528646-1-johannes.schneider@leica-geosystems.com> <20220906120645.1528646-2-johannes.schneider@leica-geosystems.com> Message-ID: X-Sender: festevam@denx.de User-Agent: Roundcube Webmail/1.3.6 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Johannes, On 06/09/2022 09:06, Johannes Schneider wrote: > + > + /* setting the baudrate triggers a reset, returning cr3 to its > + * reset value but UCR3_RXDMUXSEL "should always be set." > + * according to the imx8 reference-manual > + */ > + writel(readl(&base->cr3) | UCR3_RXDMUXSEL, &base->cr3); > + Nitpick: the recommended style for multi-line comments is: /* * Setting the baudrate triggers a reset, returning cr3 to its * reset value but UCR3_RXDMUXSEL "should always be set." * according to the imx8 reference-manual. */ Reviewed-by: Fabio Estevam