From: Dhananjay Phadke <dphadke@linux.microsoft.com>
To: Jan Kiszka <jan.kiszka@siemens.com>,
U-Boot Mailing List <u-boot@lists.denx.de>,
Simon Glass <sjg@chromium.org>
Cc: Ivan Mikhaylov <ivan.mikhaylov@siemens.com>
Subject: Re: [PATCH 0/3] mkimage: allow to specify signing algorithm
Date: Thu, 13 Jan 2022 15:28:40 -0800 [thread overview]
Message-ID: <b47ea726-775b-f004-4d1f-5e4b8ef038bc@linux.microsoft.com> (raw)
In-Reply-To: <276812c9-80e6-c430-c1cf-c19566accc02@siemens.com>
On 1/13/2022 4:38 AM, Jan Kiszka wrote:
> On 25.11.21 20:03, Jan Kiszka wrote:
>> Another step to decouple the FIT image specification from the actual
>> signing: With these changes, the signature nodes can leave out an algo
>> property, mkimage will initialize that as well while signing. This way,
>> in-tree FIT source files can be prepared for gaining signatures without
>> defining the key type or size upfront, forcing users to patch the code
>> to change that.
[resend to the list]
While encryption algo (rsa2048 vs rsa4096, etc) shouldn't need to be
explicitly specified as you noted below, how does it help to add it to
(already exhaustive) mkimage args? Parsing OID / length from keyfile
would be real change.
While rotating keys is common, how often algo is changed?
>>
>> Patch 1 is preparatory for this, patch 2 a drive-by cleanup.
>>
>> A better solution would actually be if the algorithm was derived from
>> the provided key. But the underlying crypto layer seems to be rather
>> unprepared for that.
Thanks,
DHananjay
next prev parent reply other threads:[~2022-01-13 23:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 19:03 [PATCH 0/3] mkimage: allow to specify signing algorithm Jan Kiszka
2021-11-25 19:03 ` [PATCH 1/3] image-fit: Make string of algo parameter constant Jan Kiszka
2021-11-25 19:03 ` [PATCH 2/3] mkimage: Drop unused OPT_STRING constant Jan Kiszka
2021-11-25 19:03 ` [PATCH 3/3] mkimage: Allow to specify the signature algorithm on the command line Jan Kiszka
2022-01-13 12:38 ` [PATCH 0/3] mkimage: allow to specify signing algorithm Jan Kiszka
2022-01-13 13:40 ` Simon Glass
2022-01-13 23:28 ` Dhananjay Phadke [this message]
2022-01-14 9:21 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b47ea726-775b-f004-4d1f-5e4b8ef038bc@linux.microsoft.com \
--to=dphadke@linux.microsoft.com \
--cc=ivan.mikhaylov@siemens.com \
--cc=jan.kiszka@siemens.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox