From: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v7 0/2] add command env erase
Date: Tue, 9 Jul 2019 21:52:27 +0200 [thread overview]
Message-ID: <b4909ebf-e2df-8fef-aa7e-e15e59c040e1@gmail.com> (raw)
In-Reply-To: <0376053E-2A60-4227-8D8D-58C7B79E9713@public-files.de>
Am 09.07.2019 um 21:48 schrieb Frank Wunderlich:
> Hi Simon
>
> Am 9. Juli 2019 21:23:45 MESZ schrieb Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>:
>> I remember having answered to v5, then you sent v6 and without further
>> responses sent v7. I fail to read from the patches what actually
>> changed
>> between the versions. You have written a changelog in the cover letter,
>>
>> please do so for the different patches as well.
>
> Only change between v6 and v7 is in 2/2 (mentioned in cover letter and 2/2 but there not as version history):
>
> - fix whitespaces around errmsg
That's not the point. The point is it should be in the patch so I can
jsut see it when finding the time to look at it.
I encourage you to rely on patman creating the cover letter and
changelog for you (see 'tools/patman/README').
>
> There are spaces instead of tabs i've seen after send v6. So i fixed that without waiting for responses.
That wouldn't have been a problem if the patches contained a changelog.
And for patches without changes from one version to the next, include
"-no changes" or something like that to let everyone know you did not
forget the changelog (or just use patman :)
>
> V6 has changed to be closer to saveenv like you suggested.
Yes, I've just sent by rb.
>
>> Further, you have not integrated by Reviewed-by tag to 1/2 I sent for
>> v5...
> Sorry i missed that,1/2 afair has not changed since v5
No problem, I keep forgetting that too, just wanted to let you know.
Regards,
Simon
>
>> I'll no go and manually diff v6 and v6, and then reply sigh...
>>
>> But even then, keep in mind I'm not the one mergin this!
>
> Regards Frank
>
prev parent reply other threads:[~2019-07-09 19:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-29 9:36 [U-Boot] [PATCH v7 0/2] add command env erase Frank Wunderlich
2019-06-29 9:36 ` [U-Boot] [PATCH v7 1/2] env: register erase command Frank Wunderlich
2019-07-09 19:26 ` Simon Goldschmidt
2019-07-18 23:57 ` Tom Rini
2019-06-29 9:36 ` [U-Boot] [PATCH v7 2/2] env: mmc: add erase-function Frank Wunderlich
2019-07-09 19:26 ` Simon Goldschmidt
2019-07-18 23:57 ` Tom Rini
2019-07-07 18:40 ` [U-Boot] [PATCH v7 0/2] add command env erase Frank Wunderlich
2019-07-09 19:23 ` Simon Goldschmidt
2019-07-09 19:48 ` Frank Wunderlich
2019-07-09 19:52 ` Simon Goldschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4909ebf-e2df-8fef-aa7e-e15e59c040e1@gmail.com \
--to=simon.k.r.goldschmidt@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox