From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B523C001DC for ; Thu, 27 Jul 2023 08:50:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 65F5C8677D; Thu, 27 Jul 2023 10:50:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=gmx.de header.i=xypron.glpk@gmx.de header.b="ArZOaN7Y"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 266F686795; Thu, 27 Jul 2023 10:50:13 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A047586768 for ; Thu, 27 Jul 2023 10:50:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1690447808; x=1691052608; i=xypron.glpk@gmx.de; bh=ypXvKm51B+3lIqGqcy7qy3JuuSFZY6T6mL3jrKPABpI=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=ArZOaN7YuizlOmxWWElHhBkn9B649XI2xvq2DYrv8TDXBBg5yhdt1HPXFo8U7kMgm2OBmEM RgFBzsxy16k5Oa7JnYfaUJwH6ABoQBCLIPrlMW9f/tXYELnDTjer8/lbnUSvZIM3qDPWweqlu 8EoxSL0+uQAnfcOKRGr1jsqBNxhYKteRT7d6AvkWKfb/Lh5FcMLYreZvcE3KJgiVdS9JcMMWR l/hrP/raHAKJ4Qpi24xYlfVa1ocWeSl61RY14i3UP+AbpuKMBE7ig1uSjPmxpdZUuuj59qLd7 XPcft+2MtDNp+iPtgE4d0tR/rivK0G/Oa7mxPIMm3JPzUBV3H8Kg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.123.94] ([62.143.244.162]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M4s0j-1qPlNX244F-001wFG; Thu, 27 Jul 2023 10:50:08 +0200 Message-ID: Date: Thu, 27 Jul 2023 10:50:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] test: unicode: fix a sizeof() vs ARRAY_SIZE() bug Content-Language: en-US To: Dan Carpenter Cc: Ilias Apalodimas , u-boot@lists.denx.de, Masahisa Kojima References: From: Heinrich Schuchardt In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:E8b6L38DItS3ixxAvV0chmU4WU6++CuI1vIhNYWskhholAMfUsw bhOn77Mr6iC5sl9HeyF6PsBKQXZ3kWVkfT+gzPlTEhK/WY5FlFm6d8MyzTb6fLLsYcbH7uo c6dZp0vOTsxa37O82EzRFU5KuQAMQTCuAAYPsS3N4XjDdXx3dgNA5zIirMWqrDLfy2+4Bg0 JnlzUEY4Qo0ReXcSKD4+Q== UI-OutboundReport: notjunk:1;M01:P0:QezeQOrenBQ=;HEz/eMGTbkSlCL2hLFCN18DavPC EEcmpTH78pR89YqbAzlLHn/FvjA5vG+uu3JE/aExxFVE2sne4djNFalzT6mu/RjSoO3iORt/X tNNPE3Wqq+0aZQmiBEwcqbvyYRn8p1MEOfW2NMmi5AQ13vbA7798F1WSVv43fYc7i2zih6naU DJvonoYpwALAsTVHCGYTpGvO34FzBhMvfKkYS+EMrLfqdsQxiQ/QtABXVLYeAk2VW+8LWgRxF WDTl/iAwgzG3o+dQR5gDS7/aicwmqfOcOqiPKC06li8b7LGv6L0+zdoG3/WtO/8ZLAQXOFyBi ifCYag2ZZDvy48Oorw+SaF/iPR6c4e8TbSTZqT40+yy/NA7J+blVi+Z+KgoYpx+YoJxjKWg9b 3p+pCHgGAsGq2qOxSrw9q/yPDFB3Ro+YkkCTgM1PGHJem5fl5DS8klIgcNzVaZonC1JTWdaAr BYehFl+1gU7wtWONtmT8PFfDLenZ4VpA7RDFI6LcA/JiL4qccfrRYXy46Yhl1Fq6Cz4hJ4LGD QIIqf7frDewNMu6B13lf3NTMgmBE6gXtkTPOLkTycEB36jMaS7NhjfTovZUUovPAB2v2FzgJd LnHWv2S/fvVw0ChVa82tdKGb5V2aGnzEoLasxzj3tMaDfH4aQS6rMXlfaf4gRGUgQmC8EXpkV d0rE63WRuF/zikvzaGRVhO1Pf2KU8EAnQF/FIXqhZwO+l5AuVASMyBp2qAWgzwP2m9v1WK/D5 VtWRyibxqEg8du2CmRHlIy4hfPe4QQWsw5x19SGAtajDyIO0DCL1EMZ9JLWMbOG8NVtR+xcGO lnxs2hsR7vA2JIVChkuhM35TnOaDK/z75uVPuB0mVCKsuGd0p0gfx52weeZTvT0R0Cuf0pQsU aXoiqi2IQdv+QplWcsVLRmMBJGfeRLW41rKmq+Ydxa752xv13ibfcA0Va0bRInRkrFRyqpigK cCnyDWbiqEHNTlqZWtiQfaYF3lk= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 7/27/23 09:12, Dan Carpenter wrote: > The u16_strlcat() is in units of u16 not bytes. So the limit needs to > be ARRAY_SIZE() instead of sizeof(). > Reviewed-by: Heinrich Schuchardt > Signed-off-by: Dan Carpenter > --- > test/unicode_ut.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/test/unicode_ut.c b/test/unicode_ut.c > index b27d7116b9ee..62ff5d10bf94 100644 > --- a/test/unicode_ut.c > +++ b/test/unicode_ut.c > @@ -807,12 +807,12 @@ static int unicode_test_u16_strlcat(struct unit_te= st_state *uts) > > /* dest and src are empty string */ > memset(buf, 0, sizeof(buf)); > - ret =3D u16_strlcat(buf, &null_src, sizeof(buf)); > + ret =3D u16_strlcat(buf, &null_src, ARRAY_SIZE(buf)); > ut_asserteq(1, ret); > > /* dest is empty string */ > memset(buf, 0, sizeof(buf)); > - ret =3D u16_strlcat(buf, src, sizeof(buf)); > + ret =3D u16_strlcat(buf, src, ARRAY_SIZE(buf)); > ut_asserteq(5, ret); > ut_assert(!unicode_test_u16_strcmp(buf, src, 40)); > > @@ -820,7 +820,7 @@ static int unicode_test_u16_strlcat(struct unit_test= _state *uts) > memset(buf, 0xCD, (sizeof(buf) - sizeof(u16))); > buf[39] =3D 0; > memcpy(buf, dest, sizeof(dest)); > - ret =3D u16_strlcat(buf, &null_src, sizeof(buf)); > + ret =3D u16_strlcat(buf, &null_src, ARRAY_SIZE(buf)); > ut_asserteq(6, ret); > ut_assert(!unicode_test_u16_strcmp(buf, dest, 40)); >