From: Neha Malcom Francis <n-francis@ti.com>
To: Simon Glass <sjg@chromium.org>,
U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Alper Nebi Yasak <alpernebiyasak@gmail.com>,
Lukas Funke <lukas.funke@weidmueller.com>,
Peng Fan <peng.fan@nxp.com>,
Philippe Reynes <philippe.reynes@softathome.com>,
Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>,
Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH 06/20] binman: elf: Add more debugging to LookupAndWriteSymbols()
Date: Tue, 30 Jul 2024 10:01:37 +0530 [thread overview]
Message-ID: <b7262d1e-050f-4458-b92f-e41da4e777ed@ti.com> (raw)
In-Reply-To: <20240720104950.2730773-7-sjg@chromium.org>
On 20/07/24 16:19, Simon Glass wrote:
> When symbol-writing does not appear to work, it can sometimes be hard to
> figure out what is going on. Add some more debugging to help.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> tools/binman/elf.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/binman/elf.py b/tools/binman/elf.py
> index 2ecc95f7eb8..a4694056391 100644
> --- a/tools/binman/elf.py
> +++ b/tools/binman/elf.py
> @@ -275,7 +275,7 @@ def LookupAndWriteSymbols(elf_fname, entry, section, is_elf=False,
> return 0
> base = syms.get(base_sym)
> if not base and not is_elf:
> - tout.debug('LookupAndWriteSymbols: no base')
> + tout.debug(f'LookupAndWriteSymbols: no base: elf_fname={elf_fname}, base_sym={base_sym}, is_elf={is_elf}')
> return 0
> base_addr = 0 if is_elf else base.address
> count = 0
Reviewed-by: Neha Malcom Francis <n-francis@ti.com>
--
Thanking You
Neha Malcom Francis
next prev parent reply other threads:[~2024-07-30 4:31 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-20 10:49 [PATCH 00/20] binman: Enhance FIT support for firmware Simon Glass
2024-07-20 10:49 ` [PATCH 01/20] fixdep: Support VPL Simon Glass
2024-07-29 16:19 ` Simon Glass
2024-07-20 10:49 ` [PATCH 02/20] binman: Correct an error in the FIT-template example Simon Glass
2024-07-29 16:19 ` Simon Glass
2024-07-30 4:26 ` Neha Malcom Francis
2024-07-20 10:49 ` [PATCH 03/20] binman: Tidy up bintool docs Simon Glass
2024-07-29 16:19 ` Simon Glass
2024-07-30 4:27 ` Neha Malcom Francis
2024-07-20 10:49 ` [PATCH 04/20] binman: Tidy up comment for Bintoolfdt_add_pubkey.run() Simon Glass
2024-07-29 16:19 ` Simon Glass
2024-07-20 10:49 ` [PATCH 05/20] binman: Move problem-checking code into a function Simon Glass
2024-07-29 16:19 ` Simon Glass
2024-07-20 10:49 ` [PATCH 06/20] binman: elf: Add more debugging to LookupAndWriteSymbols() Simon Glass
2024-07-29 16:19 ` Simon Glass
2024-07-30 4:31 ` Neha Malcom Francis [this message]
2024-07-20 10:49 ` [PATCH 07/20] binman: Write the compressed output to a file Simon Glass
2024-07-29 16:19 ` Simon Glass
2024-07-30 4:32 ` Neha Malcom Francis
2024-07-20 10:49 ` [PATCH 08/20] binman: Correct comment in blob_dtb GetFdtEtype() Simon Glass
2024-07-29 16:19 ` Simon Glass
2024-07-20 10:49 ` [PATCH 09/20] binman: Mention expanded entries in u-boot-vpl Simon Glass
2024-07-29 16:19 ` Simon Glass
2024-07-20 10:49 ` [PATCH 10/20] binman: Fix a comment typo in _DoReadFileDtb() Simon Glass
2024-07-29 16:19 ` Simon Glass
2024-07-20 10:49 ` [PATCH 11/20] binman: Correct indentation in testSplPubkeyDtb Simon Glass
2024-07-29 16:19 ` Simon Glass
2024-07-20 10:49 ` [PATCH 12/20] binman: Add a bintool for fdtgrep Simon Glass
2024-07-29 16:19 ` Simon Glass
2024-07-20 10:49 ` [PATCH 13/20] binman: Remove dependency on pylibfdt for entry-docs Simon Glass
2024-07-29 16:19 ` Simon Glass
2024-07-20 10:49 ` [PATCH 14/20] binman: Allow entry types to override FDT contents Simon Glass
2024-07-29 16:19 ` Simon Glass
2024-07-20 10:49 ` [PATCH 15/20] binman: Add support for alternative FDTs Simon Glass
2024-07-29 16:19 ` Simon Glass
2024-07-30 4:44 ` Neha Malcom Francis
2024-07-30 14:38 ` Simon Glass
2024-07-20 10:49 ` [PATCH 16/20] binman: fit: Allow providing FDT filenames in a directory Simon Glass
2024-07-29 16:19 ` Simon Glass
2024-07-20 10:49 ` [PATCH 17/20] binman: fit: Write the compatible string to configuration Simon Glass
2024-07-29 16:19 ` Simon Glass
2024-07-20 10:49 ` [PATCH 18/20] binman: fit: Allow running fdtgrep on devicetree blobs Simon Glass
2024-07-29 16:19 ` Simon Glass
2024-07-20 10:49 ` [PATCH 19/20] Makefile: Provide VPL devicetree and padding to binman Simon Glass
2024-07-29 16:19 ` Simon Glass
2024-07-20 10:49 ` [PATCH 20/20] Makefile: Pass OF_SPL_REMOVE_PROPS " Simon Glass
2024-07-29 16:19 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7262d1e-050f-4458-b92f-e41da4e777ed@ti.com \
--to=n-francis@ti.com \
--cc=alpernebiyasak@gmail.com \
--cc=lukas.funke@weidmueller.com \
--cc=peng.fan@nxp.com \
--cc=philippe.reynes@softathome.com \
--cc=sjg@chromium.org \
--cc=stefan.herbrechtsmeier@weidmueller.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox