From: Michal Simek <michal.simek@amd.com>
To: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>,
u-boot@lists.denx.de
Cc: git@amd.com
Subject: Re: [PATCH] board: xilinx: Add missing prototype for set_dfu_alt_info
Date: Mon, 6 Jan 2025 09:31:14 +0100 [thread overview]
Message-ID: <b7b39c45-da13-406e-ad5c-e6bdba0d8bb1@amd.com> (raw)
In-Reply-To: <20250102045026.3427121-1-venkatesh.abbarapu@amd.com>
On 1/2/25 05:50, Venkatesh Yadav Abbarapu wrote:
> Add missing prototype to fix the sparse warning,
> warning: no previous prototype for 'set_dfu_alt_info'
> [-Wmissing-prototypes].
>
> Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>
> ---
> board/xilinx/common/board.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/board/xilinx/common/board.h b/board/xilinx/common/board.h
> index 64d657673e..ff8f9b9596 100644
> --- a/board/xilinx/common/board.h
> +++ b/board/xilinx/common/board.h
> @@ -18,4 +18,6 @@ bool board_detection(void);
> char *soc_name_decode(void);
>
> bool soc_detection(void);
> +
> +void set_dfu_alt_info(char *interface, char *devstr);
> #endif /* BOARD_XILINX_COMMON_BOARD_H */
You should include <dfu.h> instead.
M
prev parent reply other threads:[~2025-01-06 8:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 4:50 [PATCH] board: xilinx: Add missing prototype for set_dfu_alt_info Venkatesh Yadav Abbarapu
2025-01-06 8:31 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7b39c45-da13-406e-ad5c-e6bdba0d8bb1@amd.com \
--to=michal.simek@amd.com \
--cc=git@amd.com \
--cc=u-boot@lists.denx.de \
--cc=venkatesh.abbarapu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox