From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75C5BC32771 for ; Wed, 28 Sep 2022 17:31:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4D72883914; Wed, 28 Sep 2022 19:31:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="UskD5c+V"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C51F483914; Wed, 28 Sep 2022 19:31:02 +0200 (CEST) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 033EC836C5 for ; Wed, 28 Sep 2022 19:30:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qt1-x834.google.com with SMTP id w2so8364709qtv.9 for ; Wed, 28 Sep 2022 10:30:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=LycaLe68mrX9NfrjS/fLSLfgPM3uxlgAoFoSzeiilY8=; b=UskD5c+V8vPdSHedD5WMdIfCOovUMfbEfgEBns7bUnBRSExlf07BUeEH0Y8k3eefES GFpuo1h230DLC9TNFLKp3dCKujidqf5Y/ENq0qoyqckWZAmBLzVUNa/e3SiF7AwN3GEc 33ycX8fLFH8G1XX7lA4WcxqG6d13AojRH4vtnFjIR28PH7EK3VRkg+7KQjuUX1bVCvNC IoVAw9gpP908/lQ7QR51fqmrUdZHoU4FzusQPHyzpUTkzDQP3HP1l9noWIU6CzRNESbi KnzCfR3JaN311mt/zp+48SIyto60rcbzSI9cM+ZxBkCWv5Xfra+GPHstL56IHmhabn3h IPwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=LycaLe68mrX9NfrjS/fLSLfgPM3uxlgAoFoSzeiilY8=; b=M8Tko0Cm9Qz5hM1lIWi5avIWZpzyZOzZc6qNnClIjukvErIoA0iJpy/6eULRMkL5UG bbFYtLxAhiqGYtkhL+YpZFcIrEETCEiVW2OtHCBX70j+kKdAyBZtWIu26h4i45DkHqy+ Ky4L/knQEpqyMsci3y+JRwGPppqHzkNaPCYXyYjMd4VrS4VIR0SW7qrKyP741xOM7Q13 6nI11jZ+9Cyf31GXHAkmY9aP11yYFLpRPIJyHZC4RTi6pUj8wOMOf7ntWAPLTyHWMzaW JdvkyfAoFXuMdTJlPnSB+RNPXmnbTWoK2053kM3bOTz3WE5Cu/WtZvlhPnmMHpqT8LXn iSdw== X-Gm-Message-State: ACrzQf31fyz+zIbrCy1LbbeMhrCs3Yt8fZv9AtDIeNekDYATgO8P+Ha4 hIEHoteqXroPuV+PXkpHgZI= X-Google-Smtp-Source: AMsMyM6AspqaF3u+QTw/PpE1X4Ypamnmg9Yt4Y9HaQHbUftD5qTnfwvrjeao9a0RD1mN7T6XMSDuJA== X-Received: by 2002:ac8:7c43:0:b0:35c:cd8f:3da5 with SMTP id o3-20020ac87c43000000b0035ccd8f3da5mr27960775qtv.61.1664386255782; Wed, 28 Sep 2022 10:30:55 -0700 (PDT) Received: from [192.168.1.201] (pool-173-73-95-180.washdc.fios.verizon.net. [173.73.95.180]) by smtp.gmail.com with ESMTPSA id j13-20020ac8440d000000b0035a6d0f7298sm3220301qtn.35.2022.09.28.10.30.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Sep 2022 10:30:55 -0700 (PDT) Message-ID: Date: Wed, 28 Sep 2022 13:30:54 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [RFC PATCH v2] clk: fix clk_get_rate() always return ulong Content-Language: en-US To: Julien Masson , u-boot@lists.denx.de Cc: Lukasz Majewski References: <87bks3wgzw.fsf@baylibre.com> From: Sean Anderson In-Reply-To: <87bks3wgzw.fsf@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 8/29/22 05:11, Julien Masson wrote: > According to clk_ops struct definition, the callback `get_rate()` > return current clock rate value as ulong. > `clk_get_rate()` should handle the clock rate returned as ulong also. > > Otherwise we may have invalid/truncated clock rate value returned by > `clk_get_rate()`. > > `log_ret` has also been removed since it use an `int` in the macro > definition. > > Signed-off-by: Julien Masson > --- > drivers/clk/clk-uclass.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c > index b89c77bf79..c351fa97d1 100644 > --- a/drivers/clk/clk-uclass.c > +++ b/drivers/clk/clk-uclass.c > @@ -469,7 +469,7 @@ void clk_free(struct clk *clk) > ulong clk_get_rate(struct clk *clk) > { > const struct clk_ops *ops; > - int ret; > + ulong ret; > > debug("%s(clk=%p)\n", __func__, clk); > if (!clk_valid(clk)) > @@ -479,11 +479,7 @@ ulong clk_get_rate(struct clk *clk) > if (!ops->get_rate) > return -ENOSYS; > > - ret = ops->get_rate(clk); > - if (ret) > - return log_ret(ret); > - > - return 0; > + return ops->get_rate(clk); > } > > struct clk *clk_get_parent(struct clk *clk) Reviewed-by: Sean Anderson