From: Andre Heider <a.heider@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 0/3] arm: mvebu: Espressobin: Set default env values at runtime
Date: Tue, 2 Feb 2021 18:24:57 +0100 [thread overview]
Message-ID: <b8fc68ae-797c-869c-3ceb-a012c9618c80@gmail.com> (raw)
In-Reply-To: <b40c0a5c-9193-ea7a-752b-0e3e468ab1e0@denx.de>
On 02/02/2021 17:32, Stefan Roese wrote:
> On 02.02.21 17:13, Andre Heider wrote:
>> On 02/02/2021 16:09, Stefan Roese wrote:
>>> Hi Pali,
>>> Hi Andre,
>>>
>>> On 12.01.21 10:24, Pali Roh?r wrote:
>>>> Hello!
>>>>
>>>> On Tuesday 12 January 2021 09:18:44 Andre Heider wrote:
>>>>> Hi Pali,
>>>>>
>>>>> On 11/01/2021 11:51, Pali Roh?r wrote:
>>>>>> Hello Stefan and Andre!
>>>>>>
>>>>>> Could you please look at this patch series and tell me what do you
>>>>>> think
>>>>>> about it? If it is fine or needs to take different approach?
>>>>>
>>>>> I like the idea very much, and I bet there're quite some boards
>>>>> which could
>>>>> make good use of "immutable envvars".
>>>>>
>>>>> The obvious review point is the filler thing and its dependency on
>>>>> DEFAULT_ENV_IS_RW, which probably won't win a beauty contest :)
>>>>> Maybe a
>>>>> nicer integration would help in getting it merged?
>>>>>
>>>>> I don't think it would take too much effort, first thing that comes
>>>>> to mind:
>>>>> - board provides list of immutable vars
>>>>> - env_set_default() backs up these vars
>>>>> - env_set_default() imports default_environment
>>>>> - env_set_default() imports backup on top
>>>>>
>>>>> The last step should be easy, see env_set_default_vars().
>>>>
>>>> This could probably work for $ethNaddr variables.
>>>>
>>>> But there is still an issue how to handle $fdtfile. There is basically
>>>> default value for this variable, but value itself cannot be determined
>>>> at compile time, only at runtime. And for it variable flags do not
>>>> help,
>>>> we just need an mechanism how to set default variable values not
>>>> only at
>>>> compile time but also runtime.
>>>>
>>>> That is why I chosen for now solution with modifying
>>>> default_environment[] array as it solve issue for both $fdtfile and
>>>> $ethNaddr variables.
>>>
>>> So what is the outcome of this discussion? Andre, do you see any
>>> hindering points in this patch series, apart from it not winning a
>>> "beauty contest"? ;)
>>
>> Hehe, nope, only aesthetic concerns, no hinderung points to block this
>> going in.
>
> I see. Then if appropriate, please send any matching tag(s) to these
> patches.
I didn't test it, so this set is at least:
Acked-by: Andre Heider <a.heider@gmail.com>
Thanks,
Andre
next prev parent reply other threads:[~2021-02-02 17:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 11:21 [PATCH 0/3] arm: mvebu: Espressobin: Set default env values at runtime Pali Rohár
2020-12-23 11:21 ` [PATCH 1/3] env: Allow to set default_environment[] from board code via compile option DEFAULT_ENV_IS_RW Pali Rohár
2020-12-23 11:21 ` [PATCH 2/3] arm: mvebu: Espressobin: Set default value for $fdtfile env variable Pali Rohár
2020-12-23 11:21 ` [PATCH 3/3] arm: mvebu: Espressobin: Set default value for $ethNaddr " Pali Rohár
2021-01-11 10:51 ` [PATCH 0/3] arm: mvebu: Espressobin: Set default env values at runtime Pali Rohár
2021-01-12 8:18 ` Andre Heider
2021-01-12 8:42 ` Andre Heider
2021-01-12 9:24 ` Pali Rohár
2021-02-02 15:09 ` Stefan Roese
2021-02-02 15:19 ` Pali Rohár
2021-02-02 16:13 ` Andre Heider
2021-02-02 16:32 ` Stefan Roese
2021-02-02 17:24 ` Andre Heider [this message]
2021-02-01 15:24 ` Pali Rohár
2021-02-08 11:33 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8fc68ae-797c-869c-3ceb-a012c9618c80@gmail.com \
--to=a.heider@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox