From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes
Date: Mon, 20 Aug 2018 22:15:33 +0200 [thread overview]
Message-ID: <b93798fc-c7cd-bd40-b203-7e71a8da8a2b@gmail.com> (raw)
In-Reply-To: <CAPnjgZ2kHsotd2NP44VzXiCk-AgBiXiXrXBKUUzLe7Nw8Yfi4Q@mail.gmail.com>
On 08/20/2018 09:29 PM, Simon Glass wrote:
[...]
>>>>> So what is the conclusion here ? Patch the design document and apply
>>>>> this patch as is ?
>>>>>
>>>>
>>>> I think we should see Simon's comments before we move forward. The
>>>> proposal I made before should come in a series, not just
>>>> documentation.
>>>
>>> This thread is too long :-)
>>>
>>> From what I understand, Marek and Bin are discussing whether a
>>> compatible string is needed to bind a driver.
>>>
>>> Generally it is. But with PCI and USB we have a search mechanism which
>>> can be used instead.
>>>
>>> The patch Marek submitted does not seems at all desirable to me.
>>
>> Can you explain why ?
>
> We already have a compatible string as the standard way to attach
> drivers to devices.
>
> For PCI, we already have PCI_DEVICE() and friends for when we can
> attach a driver for a PCI device without using a compatible string.
>
> Both of these are defined in the DT specification.
>
> The patch seems to be a rework of PCI_DEVICE() and I cannot why it is necessary.
This is explained in the patch description and the thread again. Please
read the thread before replying. Take a look at the r8a7794.dtsi and its
PCI bindings, there are PCI controller subnodes which add extra
information for PCI devices on the bus. These nodes do not have a
compatible string, only a BFD.
This is perfectly valid, since you can match a driver on the PCI IDs or
classes (PCI_DEVICE()), but the driver doesn't have a DT node associated
with it. If there is a DT node with a matching BFD, it is associated
with the driver instance by this patch.
This allows ie. the EHCI PCI driver to access that DT node and extract
information about PHYs from the DT (in case of the r8a7794).
[...]
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2018-08-20 20:15 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 13:03 [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes Marek Vasut
2018-08-08 13:14 ` Bin Meng
2018-08-08 13:24 ` Marek Vasut
2018-08-08 13:39 ` Bin Meng
2018-08-08 14:33 ` Marek Vasut
2018-08-08 15:32 ` Bin Meng
2018-08-08 19:37 ` Marek Vasut
2018-08-08 23:24 ` Bin Meng
2018-08-09 0:36 ` Marek Vasut
2018-08-09 2:37 ` Bin Meng
2018-08-09 7:54 ` Marek Vasut
2018-08-09 9:41 ` Bin Meng
2018-08-09 10:25 ` Marek Vasut
2018-08-10 3:42 ` Bin Meng
2018-08-10 10:32 ` Marek Vasut
2018-08-13 2:07 ` Bin Meng
2018-08-13 13:39 ` Tom Rini
2018-08-13 16:07 ` Marek Vasut
2018-08-13 17:16 ` Tom Rini
2018-08-14 2:34 ` Bin Meng
2018-08-14 8:54 ` Marek Vasut
2018-08-14 9:35 ` Bin Meng
2018-08-15 9:20 ` Marek Vasut
2018-08-14 19:39 ` Tom Rini
2018-08-13 13:43 ` Marek Vasut
2018-08-10 12:01 ` Tom Rini
2018-08-10 12:38 ` Marek Vasut
2018-08-13 2:24 ` Bin Meng
2018-08-13 13:46 ` Marek Vasut
2018-08-14 1:46 ` Bin Meng
2018-08-14 8:55 ` Marek Vasut
2018-08-14 9:40 ` Bin Meng
2018-08-15 9:22 ` Marek Vasut
2018-08-15 10:19 ` Bin Meng
2018-08-15 10:27 ` Marek Vasut
2018-08-15 11:25 ` Tom Rini
2018-08-16 11:47 ` Marek Vasut
2018-08-17 1:51 ` Bin Meng
2018-08-17 10:27 ` Marek Vasut
2018-08-20 7:18 ` Bin Meng
2018-08-20 8:09 ` Marek Vasut
2018-08-20 16:57 ` Simon Glass
2018-08-20 18:42 ` Marek Vasut
2018-08-20 19:29 ` Simon Glass
2018-08-20 20:15 ` Marek Vasut [this message]
2018-08-22 18:08 ` Simon Glass
2018-08-22 20:19 ` Marek Vasut
2018-08-23 10:45 ` Simon Glass
2018-08-23 12:58 ` Marek Vasut
2018-08-30 0:29 ` Simon Glass
2018-08-30 9:25 ` Marek Vasut
2018-09-01 21:45 ` Simon Glass
2018-09-01 22:43 ` Marek Vasut
2018-09-02 1:07 ` Simon Glass
2018-09-02 18:24 ` Marek Vasut
2018-09-02 23:35 ` Simon Glass
2018-09-03 0:53 ` Marek Vasut
2018-08-21 3:46 ` Bin Meng
2018-08-21 4:02 ` Marek Vasut
2018-08-21 4:15 ` Bin Meng
2018-08-21 4:30 ` Marek Vasut
2018-08-21 4:56 ` Bin Meng
2018-08-21 5:43 ` Marek Vasut
2018-08-21 7:16 ` Bin Meng
2018-08-21 10:28 ` Marek Vasut
2018-08-22 2:14 ` Bin Meng
2018-08-22 9:57 ` Marek Vasut
2018-08-23 2:11 ` Bin Meng
2018-08-23 7:42 ` Marek Vasut
2018-08-21 17:32 ` Simon Glass
2018-08-21 18:26 ` Marek Vasut
2018-08-21 18:29 ` Simon Glass
2018-08-21 18:56 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b93798fc-c7cd-bd40-b203-7e71a8da8a2b@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox