From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1401C636CC for ; Mon, 20 Feb 2023 15:51:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 62D4F85924; Mon, 20 Feb 2023 16:51:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1676908287; bh=Mtv0gXPtTrzKlCbwFaPieKTSSASWziqK4KA9Z16Ypog=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=b1bExegyaJzJ1gk8YgeSa6ou9mKQ6fsQRDFwger0C1EVuOAWEi63FDVEa5Va4Tc0M +KH63nvqkrc+ft5dcixfg3zN3IWUGyCIyWywvXV4uN/ySFaHQeFgU5K/DSV6bkbLNW ffcHy78kYKSC3MnPkk0RuIrU8tp1YMKJmN+TWJSVm8OBLMKaK/wmFReoIJLK3Z4naA fbpcLGoOG8neNYizYWZ8CYOnn9E/rv31XGWwTs82cKCeqCQJUAeMHtg8C/Kq0uIAbV 305fLhHngzQb9RFMCz879UThZhNnQYVGMrvsTCwdcEAZVenOUOSzGM1N+NLJ0feH01 IH2xb1BHkdNnw== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 9B16B80F72; Mon, 20 Feb 2023 16:51:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1676908283; bh=Mtv0gXPtTrzKlCbwFaPieKTSSASWziqK4KA9Z16Ypog=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UADGNrdNOrRmdvAkSVsl778kY9m/6N3j9m5hjopkyF+We4GoBtkwjOmv7j9w2NlMq iHA3jf4BcPFB/5zRU1S11q/bzhdgHoTN3rpBa/7w7x2QUbna76ZVZ8FmA4fyUt61l6 G8ln7/J/xT2w27WR4HJwHmyf+ezsKNbewfU9UU8+12p/RjeM7FnEbSh2p91H6lUV00 e1z4nZD9SGPDp2XgNqQ3ZDo6mW28uGjV3bXNcBP7gm+e3Lv7oM0Z4uWVh30c8B78ct JgJuV+yqaNqw5CWTGFwKZq2pFtlySKj8WlctbG1Ur3Ez4WDKGQzqhSobzEntZX7FBV 8VDtGtXMWhTNw== Message-ID: Date: Mon, 20 Feb 2023 16:51:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 08/10] phy: socionext: Add UniPhier USB3 PHY driver To: Kunihiko Hayashi , Michal Simek , Sean Anderson , Angus Ainslie , Lukasz Majewski , Jan Kiszka Cc: u-boot@lists.denx.de References: <20230220055034.4889-1-hayashi.kunihiko@socionext.com> <20230220055034.4889-9-hayashi.kunihiko@socionext.com> Content-Language: en-US From: Marek Vasut In-Reply-To: <20230220055034.4889-9-hayashi.kunihiko@socionext.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 2/20/23 06:50, Kunihiko Hayashi wrote: [...] > +static int uniphier_usb3phy_probe(struct udevice *dev) > +{ [...] > + priv->rst_parent = devm_reset_control_get_optional(dev, "gio"); > + if (IS_ERR(priv->rst_parent)) { > + printf("Failed to get parent reset\n"); > + return PTR_ERR(priv->rst_parent); > + } > + > + if (priv->clk_parent) { > + ret = clk_enable(priv->clk_parent); > + if (ret) > + return ret; > + } Missing newline here. > + if (priv->rst_parent) { > + ret = reset_deassert(priv->rst_parent); > + if (ret) > + goto out_clk_parent; > + } Reviewed-by: Marek Vasut [...]