public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@kernel.org>
To: Nishanth Menon <nm@ti.com>,
	u-boot@lists.denx.de, Tom Rini <trini@konsulko.com>
Cc: Wadim Egorov <w.egorov@phytec.de>,
	Francesco Dolcini <francesco@dolcini.it>,
	Sjoerd Simons <sjoerd@collabora.com>,
	Neha Malcom Francis <n-francis@ti.com>,
	Bryan Brattlof <bb@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Mattijs Korpershoek <mkorpershoek@baylibre.com>,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Maxime Ripard <mripard@kernel.org>
Subject: Re: [PATCH 3/3] arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1
Date: Wed, 26 Jul 2023 11:05:54 +0300	[thread overview]
Message-ID: <b991f98b-1258-94c4-be14-764cee4f61ae@kernel.org> (raw)
In-Reply-To: <20230725125856.1807742-4-nm@ti.com>

Nishanth,

On 25/07/2023 15:58, Nishanth Menon wrote:
> Update the am62 and am625 device-trees from linux v6.3-rc5 This needed the followin
> tweaks to the u-boot specific dtsi as well:
> - Switch tick-timer to the main_timer as it's now defined in the main dtsi
> - Secure proxies are defined in Soc dtsis
> - Drop duplicate nodes - u-boot.dtsi is includes in r5-sk, no need for
>   either the definitions from main.dtsi OR duplication from u-boot.dtsi
> - Add mdio pins to the cpsw3g pinctrl in u-boot dtsi. It moved to a subnode in the
>   linux dtsi that u-boot doesn't use/support
> 
> Cc: Francesco Dolcini <francesco@dolcini.it>
> Cc: Sjoerd Simons <sjoerd@collabora.com>
> Cc: Wadim Egorov <w.egorov@phytec.de>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> 
> I decided not to pick up changes from Roger and Maxime as they are'nt
> regression fixes, instead the fixups can be done on top of the basic
> sync.

This patch will cause a regression with Networking on Linux (cpsw3g)
when u-boot's DT is passed to Linux.
I will suggest that you pick Maxime's [1] and my [2] series before this patch and
squash the DT changes proposed there with this patch to avoid any regression. Thanks!

[1] - https://lore.kernel.org/all/20230724-ti-mdio-pinmux-v4-0-18541f976501@kernel.org/
[2] - https://lore.kernel.org/all/20230722193151.117345-1-rogerq@kernel.org/

-- 
cheers,
-roger

      parent reply	other threads:[~2023-07-26  8:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-25 12:58 [PATCH 0/3] arm: dts: Sync k3-am62 with upstream Nishanth Menon
2023-07-25 12:58 ` [PATCH 1/3] omap: timer: add ti,am654-timer compatibility Nishanth Menon
2023-07-25 12:58 ` [PATCH 2/3] arm: mach-k3: am62: Add timer0 id to the dev list Nishanth Menon
2023-07-25 12:58 ` [PATCH 3/3] arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1 Nishanth Menon
2023-07-25 13:56   ` Maxime Ripard
2023-07-25 14:09     ` Nishanth Menon
2023-07-25 18:17       ` Tom Rini
2023-07-26  5:56         ` Ravi Gunasekaran
2023-07-26  8:15           ` Maxime Ripard
2023-07-26 12:51             ` Nishanth Menon
2023-07-26 13:36               ` Tom Rini
2023-07-26 14:19                 ` Nishanth Menon
2023-07-26  8:05   ` Roger Quadros [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b991f98b-1258-94c4-be14-764cee4f61ae@kernel.org \
    --to=rogerq@kernel.org \
    --cc=bb@ti.com \
    --cc=francesco@dolcini.it \
    --cc=marcel.ziswiler@toradex.com \
    --cc=mkorpershoek@baylibre.com \
    --cc=mripard@kernel.org \
    --cc=n-francis@ti.com \
    --cc=nm@ti.com \
    --cc=sjoerd@collabora.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    --cc=w.egorov@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox