From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C63B7C433F5 for ; Fri, 15 Oct 2021 16:30:07 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED53361151 for ; Fri, 15 Oct 2021 16:30:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ED53361151 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8335B837DD; Fri, 15 Oct 2021 18:30:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634315404; bh=Sjvl+fMBRq5JG/qLrq7jMIyNVtTmliBSmmeV6FjjwBo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=l81+0Bkjq48YAAD0pugKiJ9bFlqcWTDP5rD9YvplrZrl0+yAPP5W2sgbfMYAYp9F6 ZLY2FnY4hcJbDmokI0oZ/nUpBCgmQ7H636KdIT3qrUv2+G+WLdMCSsBfSTfB/+dn9n qvHcg061e7CmtaC4dgkxV/kXq55l8oSBVdMCb2EY5R48TCaN1wC0rXn36KOPwdvVIp dPBHdMLMfRRCBQXbCzwGYt27XhffZ/8sBAs+WkGcEoMZGNtpeUQBOUIZNeIg14e+lu UKCJOeq3JHS1SWQDbwKLHNYLP/dai62o1KQjtJeabH6TitjkmG+JIp3Zble1rwvczT AM3vz0XLWGbLg== Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id C6D4B83695; Fri, 15 Oct 2021 18:30:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634315402; bh=Sjvl+fMBRq5JG/qLrq7jMIyNVtTmliBSmmeV6FjjwBo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ATF9JJ35gpsKCoMTB4zfAnyI5IsEr6JhE+ufvvB24KGbrRsv2o5kwWEWqnAl03zy+ gNBZ1NYVhVb5OQPmL19pqz9D3PQtXO8ZYefMqhnqN5qak3JRTOCEEttARMAW/cD3rM OEI2bTSiGM0PKipoMp1zKtijD5u0MWogRrTx7dDR2YItOHs4NNc5aEYZZv4Bok+9Lk Nufw1SrmkUTZ9HvQ6C5+Pew4Gyqkm8aXQMofhIHVxZEMh/5bmk9VkGA1rIqPKRsFPA NYx4GX6m5vrS9p1ZHbydCy1jNi6zF4Yykc+lAZa5VW4fATFTa4+oC8ToKPFhfXhOU0 bcq0V9tXqRtxA== Subject: Re: [PATCH] loads: Block writes into LMB reserved areas of U-Boot To: Tom Rini Cc: Simon Glass , U-Boot Mailing List References: <20211010215241.872206-1-marek.vasut@gmail.com> <69e586a7-7fb3-e530-d0f2-196ebb59b098@denx.de> <20211015160951.GX7964@bill-the-cat> From: Marek Vasut Message-ID: Date: Fri, 15 Oct 2021 18:30:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211015160951.GX7964@bill-the-cat> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 10/15/21 6:09 PM, Tom Rini wrote: [...] >>> This code looks OK but I don't know what lmb_reserve() and lmb_free() >>> do. Can you add comments to the header file? >> >> Not here, the entire LMB stuff needs (better) documentation, that's where >> (all) such clarification should go. > > Is that you saying you'll do such a follow-up patch, given you've > touched this code the most of late? Maybe, I won't promise you anything except I add it to my roll of todo paper.