public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tirumala Marri <tmarri@apm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc460: read get_sys_info from CPR registers instead of STRP registers
Date: Thu, 25 Aug 2011 11:05:15 -0700	[thread overview]
Message-ID: <baf20edc5bb2e77e4941331651f34187@mail.gmail.com> (raw)
In-Reply-To: <201107251355.02565.sr@denx.de>

Mike and Stefan,



>Thanks. Unfortunately this patch introduces compile errors for 460SX
boards
>(e.g. redwood):

>[stefan at kubuntu u-boot-ppc4xx (master)]$ ./MAKEALL redwood
>Configuring for redwood board...
>speed.c: In function 'get_sys_info':
>speed.c:339: error: 'PLLD_FWDVA_MASK' undeclared (first use in this
function)
>speed.c:339: error: (Each undeclared identifier is reported only once
>speed.c:339: error: for each function it appears in.)
>speed.c:340: error: 'PLLD_FWDVB_MASK' undeclared (first use in this
function)
>speed.c:341: error: 'PLLD_FBDV_MASK' undeclared (first use in this
function)
>speed.c:344: error: 'OPBDV_MASK' undeclared (first use in this function)
>speed.c:348: error: 'PERDV_MASK' undeclared (first use in this function)
>speed.c:351: error: 'CPR0_PLBED' undeclared (first use in this function)
>speed.c:352: error: 'PLBEDDV_MASK' undeclared (first use in this
function)
>speed.c:357: error: 'PLLC_FBSEL_MASK' undeclared (first use in this
function)
>make[1]: *** [speed.o] Error 1
>make[1]: *** Waiting for unfinished jobs....
>make: *** [arch/powerpc/cpu/ppc4xx/libppc4xx.o] Error 2
>make: *** Waiting for unfinished jobs....

>Could you please check, if the 460SX has the same registers and bits as
>460EX/GT and extend its header as well?

[marri] 460Ex/Gt and 460Sx has different clocking subsystems. This code
will
 Have to split to support to read the speed settings from CPU registers.

 If you can include the change to split this function we will submit our
patch
Based on yours. Please suggest.

Thanks,
Marri

  parent reply	other threads:[~2011-08-25 18:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-21 15:06 [U-Boot] [PATCH] ppc460: read get_sys_info from CPR registers instead of STRP registers Mike Williams
2011-07-25 11:55 ` Stefan Roese
2011-07-25 14:42   ` Mike Williams
2011-07-25 15:11     ` Stefan Roese
2011-07-25 18:05       ` Wolfgang Denk
2011-07-25 18:14         ` Mike Williams
2011-07-25 18:39           ` Wolfgang Denk
2011-07-26  8:00             ` Stefan Roese
2011-07-26  9:31               ` Wolfgang Denk
2011-08-05 17:45                 ` Tirumala Marri
2011-08-19 15:30                   ` Stefan Roese
2011-09-14 21:37                     ` Tirumala Marri
2011-08-24 22:16                   ` Wolfgang Denk
2011-08-25 17:09                     ` Tirumala Marri
2011-09-14 21:46                     ` Tirumala Marri
2011-08-25 18:05   ` Tirumala Marri [this message]
2011-08-26  6:01     ` Stefan Roese
2011-08-26 15:32       ` Tirumala Marri
2011-08-29 13:27         ` Mike Williams
2011-08-29 22:12           ` Tirumala Marri
  -- strict thread matches above, loose matches on Subject: below --
2011-07-20 21:35 Mike Williams
2011-07-20 22:38 ` Wolfgang Denk
2011-07-21 15:00   ` Mike Williams
2011-07-21 21:22     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=baf20edc5bb2e77e4941331651f34187@mail.gmail.com \
    --to=tmarri@apm.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox