From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F4109C433EF for ; Sat, 9 Apr 2022 02:30:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A550483D30; Sat, 9 Apr 2022 04:30:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 1464D83DA2; Sat, 9 Apr 2022 04:30:29 +0200 (CEST) Received: from mail-m17664.qiye.163.com (mail-m17664.qiye.163.com [59.111.176.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3B2ED83B29 for ; Sat, 9 Apr 2022 04:30:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [192.168.0.115] (unknown [112.49.233.126]) by mail-m17664.qiye.163.com (Hmail) with ESMTPA id 100741401E5; Sat, 9 Apr 2022 10:30:12 +0800 (CST) Message-ID: Date: Sat, 9 Apr 2022 10:30:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/2] rockchip: Enable SCSI in distro bootcmd for rk3399. Content-Language: en-US To: Vagrant Cascadian , u-boot@lists.denx.de Cc: Alex Bee , Philipp Tomsich , Philipp Tomsich , Simon Glass References: <20220406204204.60328-1-vagrant@debian.org> <20220406204204.60328-2-vagrant@debian.org> From: Kever Yang In-Reply-To: <20220406204204.60328-2-vagrant@debian.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWUJMSE9WHk5LS0tLHUlIQk 9LVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkxVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OD46FTo*Nj5DSkwQUQM4EShJ DAEKC0hVSlVKTU9CT0xKT0pJTklOVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlKSklVT0JVSUhIVUpJTVlXWQgBWUFJTU1MNwY+ X-HM-Tid: 0a800c285814da2fkuws100741401e5 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 2022/4/7 04:42, Vagrant Cascadian wrote: > Include SCSI in the list of boot targets if CONFIG_CMD_SCSI is > enabled. > > Signed-off-by: Vagrant Cascadian Reviewed-by: Kever Yang Thanks, - Kever > --- > > include/configs/rockchip-common.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h > index ba7061a287..0c08776ae2 100644 > --- a/include/configs/rockchip-common.h > +++ b/include/configs/rockchip-common.h > @@ -29,6 +29,12 @@ > #define BOOT_TARGET_NVME(func) > #endif > > +#if CONFIG_IS_ENABLED(CMD_SCSI) > + #define BOOT_TARGET_SCSI(func) func(SCSI, scsi, 0) > +#else > + #define BOOT_TARGET_SCSI(func) > +#endif > + > #if CONFIG_IS_ENABLED(CMD_USB) > #define BOOT_TARGET_USB(func) func(USB, usb, 0) > #else > @@ -57,6 +63,7 @@ > #define BOOT_TARGET_DEVICES(func) \ > BOOT_TARGET_MMC(func) \ > BOOT_TARGET_NVME(func) \ > + BOOT_TARGET_SCSI(func) \ > BOOT_TARGET_USB(func) \ > BOOT_TARGET_PXE(func) \ > BOOT_TARGET_DHCP(func) \