From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [ANN] U-Boot v2018.11 delayed a day
Date: Tue, 13 Nov 2018 12:02:20 +0100 [thread overview]
Message-ID: <bc11e783-c3b6-a331-6301-668e47484264@gmail.com> (raw)
In-Reply-To: <20181113115459.5dce801c@bbrezillon>
On 11/13/2018 11:54 AM, Boris Brezillon wrote:
> On Tue, 13 Nov 2018 11:41:48 +0100
> Marek Vasut <marek.vasut@gmail.com> wrote:
>
>> On 11/13/2018 11:33 AM, Miquel Raynal wrote:
>>> Hi Marek,
>>>
>>> +Jagan
>>>
>>> Marek Vasut <marek.vasut@gmail.com> wrote on Tue, 13 Nov 2018 03:12:49
>>> +0100:
>>>
>>>> On 11/13/2018 02:12 AM, Tom Rini wrote:
>>>>> On Tue, Nov 13, 2018 at 01:03:41AM +0100, Marek Vasut wrote:
>>>>>> On 11/12/2018 11:25 PM, Tom Rini wrote:
>>>>>>> On Mon, Nov 12, 2018 at 11:13:29PM +0100, Marek Vasut wrote:
>>>>>>>> On 11/12/2018 10:40 PM, Tom Rini wrote:
>>>>>>>>> Hey all,
>>>>>>>>>
>>>>>>>>> Since Jagan promise a v2 SPI PR for some build fixes that we should have
>>>>>>>>> in the release and I believe didn't get them out before the end of his
>>>>>>>>> day, I'm letting everyone know now to expect the release tomorrow
>>>>>>>>> instead, thanks!
>>>>>>>>
>>>>>>>> Will anyone have any chance to test those fixes to verify they didn't
>>>>>>>> break anything ?
>>>>>>>
>>>>>>> Since they're obvious enough by inspection, I'm not worried about it.
>>>>>>
>>>>>> Which patches are those ?
>>>>>
>>>>> The ones in question?
>>>>
>>>> Yes, is there a list ?
>>>
>>> I think this is the branch:
>>> https://github.com/openedev/u-boot-amarula/commits/v2-WIP5
>>
>> Ugh, patchwork links would be nice.
>
> See here [1].
>
>>
>> But for example
>> https://github.com/openedev/u-boot-amarula/commit/91d8f9979420827942ca1f336df36504bd2c1943
>>
>> is quite inobvious, and I think buggy ...
>>
>> else if (env_get_f("mtdparts", tmp_parts, sizeof(tmp_parts) != -1))
>>
>> sizeof(tmp_parts) != -1 will always be true.
>
> Indeed, I misplaced the closing parens, should be
>
> else if (env_get_f("mtdparts", tmp_parts, sizeof(tmp_parts)) != -1)
And the -1 too, even if you move the parenthesis, according to
include/common.h .
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2018-11-13 11:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 21:40 [U-Boot] [ANN] U-Boot v2018.11 delayed a day Tom Rini
2018-11-12 22:13 ` Marek Vasut
2018-11-12 22:25 ` Tom Rini
2018-11-13 0:03 ` Marek Vasut
2018-11-13 1:12 ` Tom Rini
2018-11-13 2:12 ` Marek Vasut
2018-11-13 10:33 ` Miquel Raynal
2018-11-13 10:41 ` Marek Vasut
2018-11-13 10:54 ` Boris Brezillon
2018-11-13 11:02 ` Marek Vasut [this message]
2018-11-13 11:15 ` Jagan Teki
2018-11-13 11:23 ` Marek Vasut
2018-11-13 11:32 ` Jagan Teki
2018-11-13 15:57 ` Wolfgang Denk
2018-11-13 16:06 ` Jagan Teki
2018-11-14 9:23 ` Wolfgang Denk
2018-11-14 9:50 ` Jagan Teki
2018-11-14 9:47 ` Boris Brezillon
2018-11-14 10:21 ` Wolfgang Denk
2018-11-13 13:30 ` Philipp Tomsich
2018-11-13 11:01 ` Stefano Babic
2018-11-14 11:32 ` Anatolij Gustschin
2018-11-14 11:40 ` Stefan Roese
2018-11-14 12:21 ` Tom Rini
2018-11-14 11:54 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc11e783-c3b6-a331-6301-668e47484264@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox