From: Sean Anderson <seanga2@gmail.com>
To: MD Danish Anwar <danishanwar@ti.com>, Qu Wenruo <wqu@suse.com>,
Michal Simek <michal.simek@amd.com>,
Simon Glass <sjg@chromium.org>, Stefan Roese <sr@denx.de>,
Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de, srk@ti.com,
Vignesh Raghavendra <vigneshr@ti.com>,
r-gunasekaran@ti.com, Roger Quadros <rogerq@kernel.org>
Subject: Re: [PATCH v4] misc: fs-loader: Use fw_storage_interface instead of storage_interface
Date: Wed, 7 Feb 2024 12:44:27 -0500 [thread overview]
Message-ID: <bcbcf89e-f417-849d-ce2c-bcae8dc772fe@gmail.com> (raw)
In-Reply-To: <20240130062627.2344282-1-danishanwar@ti.com>
On 1/30/24 01:26, MD Danish Anwar wrote:
> The fs-loader driver reads env storage_interface and uses it to load
> firmware file into memory using the medium set by env. Update the driver
> to use env fw_storage_interface as this variable is only used to load
> firmwares. The env storage_interface will act as fallback so that the
> existing implementations do not break.
>
> Also update the FS Loader documentation accordingly.
So why do you want to do this? I don't see what the point of renaming the
variable is, since you are not e.g. adding any new functionality, and we
have to pay for the rename in code size.
--Sean
next prev parent reply other threads:[~2024-02-07 17:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 6:26 [PATCH v4] misc: fs-loader: Use fw_storage_interface instead of storage_interface MD Danish Anwar
2024-02-02 4:50 ` Ravi Gunasekaran
2024-02-07 17:44 ` Sean Anderson [this message]
2024-02-08 5:19 ` MD Danish Anwar
2024-02-08 11:58 ` Roger Quadros
2024-02-09 9:17 ` MD Danish Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcbcf89e-f417-849d-ce2c-bcae8dc772fe@gmail.com \
--to=seanga2@gmail.com \
--cc=danishanwar@ti.com \
--cc=michal.simek@amd.com \
--cc=r-gunasekaran@ti.com \
--cc=rogerq@kernel.org \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=srk@ti.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox