Re: [PATCH v2] mx6cuboxi: Fix Ethernet after DT sync with Linux

[Josua Mayer <josua@solid-run.com>]

Hi Fabio,

Am 01.04.24 um 12:13 schrieb Christian Gmeiner:
> Hi Fabio
>
>> From: Josua Mayer <josua@solid-run.com>
>>
>> The i.MX6 Cubox-i and HummingBoards can have different PHYs at varying
>> addresses. U-Boot needs to auto-detect which phy is actually present,
>> and at which address it is responding.
>>
>> Auto-detection from multiple phy nodes specified in device-tree does not
>> currently work correct. As a work-around merge all three possible phys
>> into one node with the special address 0xffffffff which indicates to the
>> generic phy driver to probe all addresses.
>>
>> Signed-off-by: Josua Mayer <josua@solid-run.com>
>> [fabio: Added the changes to imx6qdl-sr-som-u-boot.dtsi.]
>> Signed-off-by: Fabio Estevam <festevam@gmail.com>
>> Tested-by: Christian Gmeiner <cgmeiner@igalia.com>
>> ---
>> Changes since v1:
>> - Disable ethernet-phy at addresses 0, 1 and 4.
>> - Remove the fixup of the fake 0xffffff address before booting Linux.
>>
>> Josua and Christian,
>>
>> I got access to a imx6 humming board and I was able to test it.
>>
>> This is the minimal fix I came up based on your suggestions.
>>
>> There is no need to fixup of the fake 0xffffff address before booting Linux,
>> as this fake address does not exist in Linux.
>>
>> Successfully tested Ethernet in U-Boot and in the kernel.
>>
>> Given that Ethernet is currently broken, I suggest we go with this
>> version to restore Ethernet for 2024.04.
>>
>> What do you think?
>>
> I am happy with the patch and love the idea to fix Ethernet for 2024.04.
>
> Tested-by: Christian Gmeiner <cgmeiner@igalia.com>
>
Patch looks good to me, too (however I don't have the hardware handy
for testing version with new phy)!