From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Goldschmidt Date: Wed, 9 Oct 2019 20:42:10 +0200 Subject: [U-Boot] [PATCH v2 0/4] arm: socfpga: Convert drivers from struct to defines In-Reply-To: References: <1568104683-2609-1-git-send-email-ley.foon.tan@intel.com> <1e796759-bc2e-62ac-7891-96baca9bf47b@kernel.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am 02.10.2019 um 11:23 schrieb Simon Goldschmidt: > On Wed, Oct 2, 2019 at 10:13 AM Ley Foon Tan wrote: >> >> On Wed, Sep 18, 2019 at 12:23 PM Simon Goldschmidt >> wrote: >>> >>> >>> >>> Ley Foon Tan schrieb am Mi., 18. Sep. 2019, 04:32: >>>> >>>> On Wed, Sep 18, 2019 at 6:33 AM Dinh Nguyen wrote: >>>>> >>>>> >>>>> >>>>> On 9/10/19 3:37 AM, Ley Foon Tan wrote: >>>>>> This is 2nd version of patchset to convert reset, system and clock manager >>>>>> drivers to use #define instead of struct. >>>>>> >>>>>> Tested on Cyclone 5, Arria 10 and Stratix 10 devices. >>>>>> >>>>>> Patch 1 is new one, patch 2 to 4 have changes. >>>>>> >>>>>> Main changes in this version are: >>>>>> - Get base address from DT >>>>>> - Change to use writel(), readl(), setbits_le32() and clrbits_le32(). >>>>>> - Add prefix to defines. >>>>>> - Add "u-boot,dm-pre-reloc" to clock and system manager nodes. >>>>>> >>>>>> History: >>>>>> v1: https://patchwork.ozlabs.org/cover/1149731/ >>>>>> >>>>> >>>>> I think you also need to Simon Goldschmidt to this series. >>>> Simon is in the CC list in my original email. >>> >>> >>> And I'm trying my best to catch up with u-boot mails and patches. I already read it through but failed to find the time to review and test it. Next week, hopefully... >>> >>> Regards, >>> Simon >>> >>>>> >>>>> Beside the minor incorrect address missing a zero in patch 1, I've >>>>> tested this series on the Sockit. >>>>> >>>>> Tested-by: Dinh Nguyen >> >> Hi Marek and Simon >> >> Any further comment for this series? Otherwise, I will send v3 with >> minor change for Dinh's comment. > > I did my best to catch up now. Ping back if there are still patches missing/ > uncommented, please. So could we have v3 with those minor changes (and adjusted commit messages)? I'd like to base my series on these changes to prevent merge conflicts. Thanks, Simon > > Regards, > Simon >