From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A127CC76196 for ; Tue, 11 Apr 2023 08:00:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 60E7E85D99; Tue, 11 Apr 2023 09:59:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1681199999; bh=8T2kvrCutOplk1C4rV5+Q98rl7isoGSVdqTTxSN3GNg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Reply-To:From; b=lswHRmX4bkHAqWarJe98AjKS7zPNwC7JGbUTHzNV97Xpd2Nl7Y4EZvOkXQ+TwkZYH kO00Ahv3sPKlWz9EXcM+6rGWmrrBOKlFy1RpiXXH5Q1r1UofPABtODqQa5u22ZtBYg cUd1IqqYrOjLqO7609rc9spil27BpPAQ7Z0jOWVfQSk88q4N9GtZEfwmqZu2E8kXoR MK4jTiQYawFZtt1hP5ii0DebUpBHrxnvkFqfKSwhWs2NXUzI8O+Chm3mJExdJt3Zid NC2Hb1q7oMYqZon/FaSAQ9Va0JweJXm2t1NwOwd8Iyv/z35kOkjaRaTSuSiPYwkUAH RQrtHLeAkJjGA== Received: from [192.168.1.107] (89-186-115-51.pool.digikabel.hu [89.186.115.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: hs@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 7311D85D52; Tue, 11 Apr 2023 09:59:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1681199996; bh=8T2kvrCutOplk1C4rV5+Q98rl7isoGSVdqTTxSN3GNg=; h=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From; b=xPupV+WrvTB6LdE+nJtqL1ZfJogn4zU3H8//TINF7gEdPlKnSEwVGmYJ6zg4Pmo70 KkQ2y3eDM7TviFrVHoNhbuztBGah4W901dE8T3DErDGm/Gn/K4BbSR66fbJp+CyMLg 6WJscvF3kRpPiAWf+FSkkEN8JAVQyAMh8WMRzYedS7VQLvPSZd4Qwi/O/o2FWKdPjW dtnPiFSM+RlcQR06WqIO9pVeNW6ykd76i1iNjQC+azry8KCjn9J1V4TLgFA/6T5HFZ m3i6MP3RhF9ECeH43yUSvImWDkeIIt95XX9kcGiamzqraA9vUGk7tBPS0785rJeiFm 70mqjtuGgvmcw== Subject: Re: [PATCH 6/6] m68k: upgrading all boards to dm i2c To: Angelo Dureghello , trini@konsulko.com Cc: u-boot@lists.denx.de, mario.six@gdsys.cc References: <20230404225928.3032456-1-angelo@kernel-space.org> <20230404225928.3032456-6-angelo@kernel-space.org> From: Heiko Schocher Message-ID: Date: Tue, 11 Apr 2023 10:00:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: hs@denx.de Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hello Angelo, On 11.04.23 09:40, Angelo Dureghello wrote: > Hi Helko, > > On 11/04/23 6:41 AM, Heiko Schocher wrote: >> Hello Angelo, >> >> On 05.04.23 00:59, Angelo Dureghello wrote: >>> Upgrading all board configs where i2c is involved to DM i2c. >>> >>> Signed-off-by: Angelo Dureghello >>> --- >>>   configs/M5208EVBE_defconfig           | 5 +---- >>>   configs/M5235EVB_Flash32_defconfig    | 1 + >>>   configs/M5235EVB_defconfig            | 1 + >>>   configs/M5253DEMO_defconfig           | 5 +---- >>>   configs/M5275EVB_defconfig            | 5 +---- >>>   configs/M53017EVB_defconfig           | 6 ++---- >>>   configs/M5329AFEE_defconfig           | 6 ++---- >>>   configs/M5329BFEE_defconfig           | 6 ++---- >>>   configs/M5373EVB_defconfig            | 3 ++- >>>   configs/astro_mcf5373l_defconfig      | 6 ++---- >>>   configs/eb_cpu5282_defconfig          | 5 ++--- >>>   configs/eb_cpu5282_internal_defconfig | 5 ++--- >>>   configs/stmark2_defconfig             | 4 ++++ >>>   13 files changed, 23 insertions(+), 35 deletions(-) >> >> Thanks for this series, I did not find a cover letter Email, >> so I have here a common question: >> >> You rename in patch 1/6 >> >> CONFIG_SYS_I2C_0 -> CFG_SYS_I2C_0 >> >> but only add in patch 2/6 for the stmark2 this renamed define, >> and add DTS nodes for other boards in patch 5/6 and here the >> defconfig changes... may I oversee something obvious, but do >> the other boards not also need some CFG_SYS_I2C_0 define? >> > > CFG_SYS_I2C_0 (0 to 5) it's a define to setup pads pinmux to i2c, > but only for coldfire mcf5441x family that requires this. Ah! > m68k/cpu/mcf5445x/cpu_init.c:#ifdef CFG_SYS_I2C_0 > > Involved board is only stmark2, that is the board > i am using here for test. I found this define to be set > because i2c was not working, so i moved in the more proper > CFG_ namespace. Fine. > I cannot test other boards actually, but i don't find any > similar define/need in their start code, so i am supposing > other cpu families are not needing it, or using other > definitions for pinmux. > > I would like one day to add pinmux setup from fdt, Nice to hear! > but not trivial, linux does not have fdt implementation for > coldfire, so need to invent it from scratch. Yes, that would be preferred solution! So, for me, your series is fine to me, Thanks! bye, Heiko > > >> Thanks! >> >> bye, >> Heiko > > Thanks, > Regards, > angelo > -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de