public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sjoerd Simons <sjoerd@collabora.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>,
	U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Maxim Cournoyer <maxim.cournoyer@savoirfairelinux.com>,
	Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH 1/2] Revert "patman: invoke the checkpatch.pl script with '--u-boot' and '--strict'"
Date: Mon, 16 Jan 2023 10:19:19 +0100	[thread overview]
Message-ID: <bec967028ef759cac103149307e20ff2db073dce.camel@collabora.com> (raw)
In-Reply-To: <20230113135051.22738-1-maxim.cournoyer@savoirfairelinux.com>

On Fri, 2023-01-13 at 08:50 -0500, Maxim Cournoyer wrote:
> This reverts commit 648d8186dd7f9c444fb07f355090d275dcdd4de4, because
> it broke usage of patman on Linux, whose check script doesn't know
> about '--strict' or '--u-boot'.

I can confirm that this reverts fixes the reported issue:

Tested-by: Sjoerd Simons <sjoerd@collabora.com>

> 
> Reported-by: Sjoerd Simons <sjoerd@collabora.com>
> Signed-off-by: Maxim Cournoyer <maxim.cournoyer@savoirfairelinux.com>
> ---
> 
>  tools/patman/checkpatch.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/patman/checkpatch.py b/tools/patman/checkpatch.py
> index 012c0d895c..d1b902dd96 100644
> --- a/tools/patman/checkpatch.py
> +++ b/tools/patman/checkpatch.py
> @@ -211,7 +211,7 @@ def check_patch(fname, verbose=False,
> show_types=False, use_tree=False):
>              stdout: Full output of checkpatch
>      """
>      chk = find_check_patch()
> -    args = [chk, '--u-boot', '--strict']
> +    args = [chk]
>      if not use_tree:
>          args.append('--no-tree')
>      if show_types:
> 
> base-commit: 87c9e117bf57d6bb42c5521a3f6ec9ca7d97e5fa

-- 
Sjoerd Simons
Collabora Ltd.

  parent reply	other threads:[~2023-01-16  9:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13 13:50 [PATCH 1/2] Revert "patman: invoke the checkpatch.pl script with '--u-boot' and '--strict'" Maxim Cournoyer
2023-01-13 13:50 ` [PATCH 2/2] patman: symlink top level .checkpatch.conf Maxim Cournoyer
2023-01-13 18:00   ` Simon Glass
2023-01-19  2:11     ` Simon Glass
2023-01-13 18:00 ` [PATCH 1/2] Revert "patman: invoke the checkpatch.pl script with '--u-boot' and '--strict'" Simon Glass
2023-01-16  9:19 ` Sjoerd Simons [this message]
2023-01-19  2:11   ` Simon Glass
2023-01-19 10:24     ` Marcel Ziswiler
2023-01-19 16:19       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bec967028ef759cac103149307e20ff2db073dce.camel@collabora.com \
    --to=sjoerd@collabora.com \
    --cc=maxim.cournoyer@gmail.com \
    --cc=maxim.cournoyer@savoirfairelinux.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox