From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D067BC46467 for ; Mon, 16 Jan 2023 09:19:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2F4FE8552C; Mon, 16 Jan 2023 10:19:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="nzQU4GsF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7C9A585531; Mon, 16 Jan 2023 10:19:24 +0100 (CET) Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1DF8385258 for ; Mon, 16 Jan 2023 10:19:22 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjoerd@collabora.com Received: from beast.luon.net (unknown [IPv6:2a10:3781:2531:0:26cc:6c0f:ebfb:d967]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sjoerd) by madras.collabora.co.uk (Postfix) with ESMTPSA id 6B04A6602BBC; Mon, 16 Jan 2023 09:19:21 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1673860761; bh=a03+K5Vlpb70BpbNdydqvuX1m/gSRRSjIxJjcFwwMj8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=nzQU4GsFaKRvvngDrR0PazFZdInedxogVrWehoKqiLN0U4z3XqjFi4xdl4KWYu5KH bGi8oCUIXo0/tlXO26RRoleAmrPMmvy66zmo2sR+15xT+Mo17HFaA9sMQmCLlzaerq 9qk8nFir7Vx11pgu5YpJc9k7pMxOi/3r7WGb3XXuFuoimk0ORmmqAfIbnOs8sn8GAI Yznb4/B1J6vkZs1t6I5o0T9BHey+dG758NFAzkIhVb+DGOxMGy8LvLyqd5aW3TntE2 +e5wKO4KLERiykVM/Mc96darabu8p28gk7PEU1LhJwKnCk9DCZcDE4FmKQdMjFZ1YU k1+fe+VOrJ1vw== Received: by beast.luon.net (Postfix, from userid 1000) id 4C5EE613BB78; Mon, 16 Jan 2023 10:19:19 +0100 (CET) Message-ID: Subject: Re: [PATCH 1/2] Revert "patman: invoke the checkpatch.pl script with '--u-boot' and '--strict'" From: Sjoerd Simons To: Maxim Cournoyer , U-Boot Mailing List Cc: Maxim Cournoyer , Simon Glass Date: Mon, 16 Jan 2023 10:19:19 +0100 In-Reply-To: <20230113135051.22738-1-maxim.cournoyer@savoirfairelinux.com> References: <20230113135051.22738-1-maxim.cournoyer@savoirfairelinux.com> Organization: Collabora Ltd. Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.2-1 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Fri, 2023-01-13 at 08:50 -0500, Maxim Cournoyer wrote: > This reverts commit 648d8186dd7f9c444fb07f355090d275dcdd4de4, because > it broke usage of patman on Linux, whose check script doesn't know > about '--strict' or '--u-boot'. I can confirm that this reverts fixes the reported issue: Tested-by: Sjoerd Simons >=20 > Reported-by: Sjoerd Simons > Signed-off-by: Maxim Cournoyer > --- >=20 > =C2=A0tools/patman/checkpatch.py | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tools/patman/checkpatch.py b/tools/patman/checkpatch.py > index 012c0d895c..d1b902dd96 100644 > --- a/tools/patman/checkpatch.py > +++ b/tools/patman/checkpatch.py > @@ -211,7 +211,7 @@ def check_patch(fname, verbose=3DFalse, > show_types=3DFalse, use_tree=3DFalse): > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = stdout: Full output of checkpatch > =C2=A0=C2=A0=C2=A0=C2=A0 """ > =C2=A0=C2=A0=C2=A0=C2=A0 chk =3D find_check_patch() > -=C2=A0=C2=A0=C2=A0 args =3D [chk, '--u-boot', '--strict'] > +=C2=A0=C2=A0=C2=A0 args =3D [chk] > =C2=A0=C2=A0=C2=A0=C2=A0 if not use_tree: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 args.append('--no-tree') > =C2=A0=C2=A0=C2=A0=C2=A0 if show_types: >=20 > base-commit: 87c9e117bf57d6bb42c5521a3f6ec9ca7d97e5fa --=20 Sjoerd Simons Collabora Ltd.