From: Marek Vasut <marek.vasut@mailbox.org>
To: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de,
Mattijs Korpershoek <mkorpershoek@kernel.org>,
Marek Vasut <marek.vasut+usb@mailbox.org>
Subject: Re: [PATCH] usb: gadget: Move USB_GADGET_DUALSPEED to be slightly more visible
Date: Thu, 19 Mar 2026 01:50:56 +0100 [thread overview]
Message-ID: <bf3bb11e-e891-4703-ad47-04d53e21d7af@mailbox.org> (raw)
In-Reply-To: <20260318012649.GG502704@bill-the-cat>
On 3/18/26 2:26 AM, Tom Rini wrote:
> On Tue, Mar 17, 2026 at 08:42:06PM +0100, Marek Vasut wrote:
>> On 3/17/26 2:41 PM, Tom Rini wrote:
>>> On Tue, Mar 17, 2026 at 03:34:36AM +0100, Marek Vasut wrote:
>>>> On 3/17/26 2:24 AM, Tom Rini wrote:
>>>>> As exposed by "make randconfig", we have an issue around
>>>>> USB_GADGET_DUALSPEED. It is possible to select this symbol (via
>>>>> SPL_USB_CDNS3_GADGET for example) and so have an unmet dependency. As
>>>>> this is a hidden symbol, move it up within the menu.
>>>> What is the issue this is fixing ?
>>>
>>> Valid configs causing the kconfig part of the build system to note
>>> unmet dependencies.
>> Lemme rephrase, is this actually a fix, or is this some readability/ordering
>> improvement patch ?
>
> Yes, it's a fix because randconfig finds problems that users may stumble
> on to while trying to make a valid config for a platform.
Is the commit message telling me, that "config USB_GADGET_DUALSPEED" is
moved outside of the "if USB_GADGET" block ?
Because if this is something else, and the symbols are simply reordered,
that I do not understand how this could be fixing anything.
next prev parent reply other threads:[~2026-03-19 4:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 1:24 [PATCH] usb: gadget: Move USB_GADGET_DUALSPEED to be slightly more visible Tom Rini
2026-03-17 2:34 ` Marek Vasut
2026-03-17 13:41 ` Tom Rini
2026-03-17 19:42 ` Marek Vasut
2026-03-18 1:26 ` Tom Rini
2026-03-19 0:50 ` Marek Vasut [this message]
2026-03-19 13:39 ` Tom Rini
2026-03-19 17:57 ` Marek Vasut
2026-03-20 13:53 ` Tom Rini
2026-03-21 1:53 ` Marek Vasut
2026-03-21 17:34 ` Tom Rini
2026-03-21 18:50 ` Marek Vasut
2026-03-23 14:32 ` [PATCH v2] " Tom Rini
2026-03-23 15:05 ` Marek Vasut
2026-03-26 8:57 ` Mattijs Korpershoek
2026-04-08 9:26 ` Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf3bb11e-e891-4703-ad47-04d53e21d7af@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=marek.vasut+usb@mailbox.org \
--cc=mkorpershoek@kernel.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox