From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4338C47082 for ; Mon, 31 May 2021 19:01:22 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D06536128A for ; Mon, 31 May 2021 19:01:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D06536128A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D937B82E9E; Mon, 31 May 2021 21:01:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="sgLEoBcH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6620E82EA6; Mon, 31 May 2021 21:01:16 +0200 (CEST) Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4B8A482E9A for ; Mon, 31 May 2021 21:01:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mr.nuke.me@gmail.com Received: by mail-oi1-x22a.google.com with SMTP id a13so7727111oid.9 for ; Mon, 31 May 2021 12:01:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3F0EDNEsRBAwGf4FU8yUaclRChGif/3+iJlUCwo0VnE=; b=sgLEoBcHHly877funMcSSUVbfTw/Im3AHf8dcPbtjjfJh5HeXGaUvYJW0pfBLi/6Fs qld8WeBUV2hcSNrvCRBMFgv2In0WiYB7klWYk/RBntS6oX15jS8xuHSQfAf4SOfJRwda LUR96JjQ9XOP9dbWC9Owh4KDPNechh8P/GFcYbc8MYmt69aurMVd0tBE74dXTew9G7z0 QNQUE2Q2MlN4oRLr+IAHehVrS9nRQxCBi4ju1m3hhy/8ZqpAfzAWBHZUtxe1w1Ky/kBl q5vfPsfAIarRZmMo/OhLbPHnsJiw9fGjJZZ71s/BD6YIwuGCtwjEXmERWcr1riUlixAZ z0VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3F0EDNEsRBAwGf4FU8yUaclRChGif/3+iJlUCwo0VnE=; b=htNwj6ffm/gCPI96ow31DRosrTb6a83FVP0cLvPdlFUoJ4aUvcgzOBIlQWbvFGEHww zdIUUnKEiNe50/ew+pzns1VnbOWYQv+Bn7VyzrBsksZDckkgmdSnaXFr5U+CYVCK8aTB N6IbaK39DrhCcKFVffLVMrXg4ytiQ2s/ng5xdddC00Rel41ENa9ebZ46v/Z9akQn8/M8 44UFJ9IYlnbWU6imWFJ/N7T601Ics8Gue7f1epoyEPCwugeiydBWJ4MOYS90WeQKOd0c mpoWojjpVAUrn8gFYFq4px0KlD10yUCiRlbF7BdSGqQKLP8taak+gF5QsqT3UBAdHXVg eu0g== X-Gm-Message-State: AOAM530Lb1fr2/Pa74Lcrs4Slud8ShxDQva0yFKCwh5ycpDCufkWA8fF esXb7EK5qAh2+KRU9EeYHt4= X-Google-Smtp-Source: ABdhPJz/Kjx9nQfsHeRtChF57k9KgA/LCHUsnSFE2MSuA2mA4e/rpDAlSKlQAY2b689aL55hh7zh+A== X-Received: by 2002:a54:4113:: with SMTP id l19mr350303oic.38.1622487671736; Mon, 31 May 2021 12:01:11 -0700 (PDT) Received: from nuclearis3.gtech (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id 7sm3201514oti.30.2021.05.31.12.01.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 May 2021 12:01:11 -0700 (PDT) Subject: Re: U-Boot "lib: Add support for ECDSA image signing" commit breaks socfpga_*_atf_defconfig compilation To: "Lim, Elly Siew Chin" , "u-boot@lists.denx.de" , Simon Glass Cc: "Tan, Ley Foon" , "Gan, Yau Wai" , "Chee, Tien Fong" , "See, Chin Liang" , "Westergreen, Dalon" References: <76b0d5c1-4684-132f-8c82-230443a6c2f6@gmail.com> From: "Alex G." Message-ID: Date: Mon, 31 May 2021 14:01:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean On 4/24/21 2:43 AM, Lim, Elly Siew Chin wrote: > Add this discussion to denx mailing list. [snip] > > I can think of two enhancement to fix this: > (1) Add separate CONFIG to gate ECDSA algorithm. This enhancement benefits all use cases. I assume not all user need ECDSA algorithm when FIT_SIGNATURE is used. > (2) Enhance spl/spl_fit.c to support verification of data integrity based on hash(es) in FIT image instead of based on FIT_SIGNATURE. > > > What do you think? If you agree: > For (1), can we ask Alex's help to change it? > For (2), who will be the right person to change this kind of common code? > FYI, I proposed a change to decouple OpenSSL from FIT_SIGNATURE [1] [1] https://patchwork.ozlabs.org/project/uboot/patch/20210524202317.1492578-1-mr.nuke.me@gmail.com/ That would enable you to have FIT_SIGNATURE, but not need OpenSSL support in mkimage. Alex