Re: [PATCH next 1/4] rockchip: ringneck-px30: disable broken USB gadget

[Kever Yang <kever.yang@rock-chips.com>]

Hi Quentin,

On 2024/6/14 19:04, Quentin Schulz wrote:
> From: Quentin Schulz <quentin.schulz@cherry.de>
>
> USB gadget simply doesn't work right now on PX30. Tested on PX30 EVB and
> PX30 Ringneck with Linux mainline and Rockchip 5.10 Linux as well as
> U-Boot.
Do you mean for both U-Boot and kernel, including mainline version and 
rockchip version,
and on both PX30 EVB and Ringneck board, all SW&HW have no USB gadget 
working?
So when you test this, does the maskrom mode works? because it sounds 
like maybe
the HOST PC is the one have issue at the moment.


Thanks,

  - Kever

>
> We don't want to our users to assume that USB gadget is supported on Q7
> USB P1 on Ringneck Haikou, so let's remove its support, which also
> removes the ums CLI command, fastboot and Android image booting
> support.
>
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
> ---
>   configs/ringneck-px30_defconfig | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/configs/ringneck-px30_defconfig b/configs/ringneck-px30_defconfig
> index 23204794205..2ec5f72e47a 100644
> --- a/configs/ringneck-px30_defconfig
> +++ b/configs/ringneck-px30_defconfig
> @@ -15,7 +15,6 @@ CONFIG_DEBUG_UART_BASE=0xFF030000
>   CONFIG_DEBUG_UART_CLOCK=24000000
>   CONFIG_SYS_LOAD_ADDR=0x800800
>   CONFIG_DEBUG_UART=y
> -# CONFIG_ANDROID_BOOT_IMAGE is not set
>   CONFIG_FIT=y
>   CONFIG_FIT_VERBOSE=y
>   CONFIG_SPL_LOAD_FIT=y
> @@ -42,6 +41,7 @@ CONFIG_SPL_ATF=y
>   # CONFIG_CMD_ELF is not set
>   # CONFIG_CMD_LZMADEC is not set
>   # CONFIG_CMD_UNZIP is not set
> +CONFIG_CMD_BIND=y
>   CONFIG_CMD_GPIO=y
>   CONFIG_CMD_GPT=y
>   CONFIG_CMD_I2C=y
> @@ -49,7 +49,6 @@ CONFIG_CMD_I2C=y
>   # CONFIG_CMD_LOADS is not set
>   CONFIG_CMD_MMC=y
>   CONFIG_CMD_USB=y
> -CONFIG_CMD_USB_MASS_STORAGE=y
>   # CONFIG_CMD_SETEXPR is not set
>   CONFIG_CMD_PMIC=y
>   CONFIG_CMD_REGULATOR=y
> @@ -73,8 +72,6 @@ CONFIG_BUTTON=y
>   CONFIG_BUTTON_GPIO=y
>   CONFIG_CLK=y
>   CONFIG_SPL_CLK=y
> -CONFIG_FASTBOOT_BUF_ADDR=0x800800
> -CONFIG_FASTBOOT_BUF_SIZE=0x04000000
>   CONFIG_GPIO_HOG=y
>   CONFIG_SPL_GPIO_HOG=y
>   CONFIG_ROCKCHIP_GPIO=y
> @@ -112,8 +109,6 @@ CONFIG_DM_THERMAL=y
>   CONFIG_USB=y
>   CONFIG_USB_EHCI_HCD=y
>   CONFIG_USB_EHCI_GENERIC=y
> -CONFIG_USB_GADGET=y
> -CONFIG_USB_GADGET_DWC2_OTG=y
>   CONFIG_SPL_TINY_MEMSET=y
>   CONFIG_TPL_TINY_MEMSET=y
>   CONFIG_LZO=y
>