From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 230CDCCA47E for ; Wed, 15 Jun 2022 14:29:42 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A79B3844E4; Wed, 15 Jun 2022 16:29:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="boOON4uv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A9C21844E7; Wed, 15 Jun 2022 16:29:39 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D5A8D844B8 for ; Wed, 15 Jun 2022 16:29:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rogerq@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C264860ACD; Wed, 15 Jun 2022 14:29:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36525C34115; Wed, 15 Jun 2022 14:29:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655303373; bh=lNHIarne0VrKhthfJqsV/vBx3lXIKMyq0XbqGrFukuw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=boOON4uvAqIw+vS1qyfrLOmJIZT51lW1J2NKoEV/pWIpQ5jgAFH9X20EGdU2ri65w gBPl8+zDcpPucmgGToLMl1SX/B0mEmZxFX+NQdaGk68ua7sODBsrFUINqzey0qk5Rl KnXU2bovnR7cNSKvw41eUDTkykr2flNTpTlsKfoHKjx7knQOqAujacNCSY6gVrolg4 JyfSyvMPz9NWdgG1P6FMTfiMGXrw8QlrumrtJsEEvcQUIA7W8oyfsGrRZeJWzjfIB3 Zt0AWROaU3Ro4eBSnQZlBWrZNXAoHZq5m6u6SIt9irTFsqpgGMsSCmrEKSrgZMZQiP lJ+JmxEDlzwxg== Message-ID: Date: Wed, 15 Jun 2022 17:29:29 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH RFC v3 10/11] ti: dtsi: j721e: Use binman to package tispl.bin Content-Language: en-US To: Neha Malcom Francis , trini@konsulko.com, alpernebiyasak@gmail.com, a-govindraju@ti.com, vigneshr@ti.com Cc: u-boot@lists.denx.de, afd@ti.com References: <20220615064804.29553-1-n-francis@ti.com> <20220615064804.29553-11-n-francis@ti.com> From: Roger Quadros In-Reply-To: <20220615064804.29553-11-n-francis@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 15/06/2022 09:48, Neha Malcom Francis wrote: > tispl.bin must be packaged (with ATF, OPTEE, DM and A72 SPL) for J721E. > Binman picks up and packages entries according to the > description given in the device tree. > > k3-j721e-a72-binman.dtsi has been introduced for A72 specific binman > node. It is included by k3-j721e-common-proc-board-u-boot.dtsi > > Signed-off-by: Neha Malcom Francis > --- > arch/arm/dts/k3-j721e-a72-binman.dtsi | 86 +++++++++++++++++++ > .../k3-j721e-common-proc-board-u-boot.dtsi | 1 + > board/ti/j721e/Kconfig | 1 + > 3 files changed, 88 insertions(+) > create mode 100644 arch/arm/dts/k3-j721e-a72-binman.dtsi > > diff --git a/arch/arm/dts/k3-j721e-a72-binman.dtsi b/arch/arm/dts/k3-j721e-a72-binman.dtsi > new file mode 100644 > index 0000000000..beb3424bb9 > --- /dev/null > +++ b/arch/arm/dts/k3-j721e-a72-binman.dtsi > @@ -0,0 +1,86 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +// Copyright (C) 2022 Texas Instruments Incorporated - https://www.ti.com/ > + > +#include > + > +#ifdef CONFIG_ARM64 > +/ { > + binman: binman { > + multiple-images; > + }; > +}; > + > +&binman { > + tispl { > + filename = "tispl.bin"; > + fit { > + description = "FIT IMAGE"; > + #address-cells = <1>; > + images { > + atf { > + description = "ARM Trusted Firmware"; > + type = "firmware"; > + arch = "arm64"; > + compression = "none"; > + os = "arm-trusted-firmware"; > + load = ; > + entry = ; > + atf-bl31 { > + }; > + }; > + tee { > + description = "OPTEE"; > + type = "tee"; > + arch = "arm64"; > + compression = "none"; > + os = "tee"; > + load = <0x9e800000>; > + entry = <0x9e800000>; > + tee-os { > + }; > + }; > + dm { > + description = "DM binary"; > + type = "firmware"; > + arch = "arm32"; > + compression = "none"; > + os = "DM"; > + load = <0x89000000>; > + entry = <0x89000000>; > + ti-dm { > + }; > + }; > + spl { > + description = "SPL (64-bit)"; > + type = "standalone"; > + os = "U-Boot"; > + arch = "arm64"; > + compression = "none"; > + load = ; > + entry = ; > + u-boot-spl-nodtb { > + }; > + }; > + k3-j721e-common-proc-board.dtb { how about fdt-1 for node name? > + description = "k3-j721e-common-proc-board"; > + type = "flat_dt"; > + arch = "arm"; > + compression = "none"; > + blob-ext { > + filename = "spl/dts/k3-j721e-common-proc-board.dtb"; > + }; > + }; > + }; > + configurations { > + default = "conf"; > + conf { > + description = "k3-j721e-common-proc-board"; > + firmware = "atf"; > + loadables = "tee", "dm", "spl"; > + fdt = "k3-j721e-common-proc-board.dtb"; > + }; > + }; > + }; > + }; > +}; > +#endif > diff --git a/arch/arm/dts/k3-j721e-common-proc-board-u-boot.dtsi b/arch/arm/dts/k3-j721e-common-proc-board-u-boot.dtsi > index 677a72d2a2..6490d71f7e 100644 > --- a/arch/arm/dts/k3-j721e-common-proc-board-u-boot.dtsi > +++ b/arch/arm/dts/k3-j721e-common-proc-board-u-boot.dtsi > @@ -4,6 +4,7 @@ > */ > > #include > +#include "k3-j721e-a72-binman.dtsi" > > / { > chosen { > diff --git a/board/ti/j721e/Kconfig b/board/ti/j721e/Kconfig > index a3a9d504ae..3cf05f0d3b 100644 > --- a/board/ti/j721e/Kconfig > +++ b/board/ti/j721e/Kconfig > @@ -14,6 +14,7 @@ config TARGET_J721E_A72_EVM > select BOARD_LATE_INIT > imply TI_I2C_BOARD_DETECT > select SYS_DISABLE_DCACHE_OPS > + select BINMAN > > config TARGET_J721E_R5_EVM > bool "TI K3 based J721E EVM running on R5" cheers, -roger