From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54815C001DE for ; Fri, 28 Jul 2023 09:47:51 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 280CE868A1; Fri, 28 Jul 2023 11:47:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 325F8868AB; Fri, 28 Jul 2023 11:47:47 +0200 (CEST) Received: from mail-m11886.qiye.163.com (mail-m11886.qiye.163.com [115.236.118.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 187C48689D for ; Fri, 28 Jul 2023 11:47:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [172.16.12.93] (unknown [58.22.7.114]) by mail-m11886.qiye.163.com (Hmail) with ESMTPA id EFC9B8027F; Fri, 28 Jul 2023 17:47:18 +0800 (CST) Message-ID: Date: Fri, 28 Jul 2023 17:47:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 2/3] cmd: ini: Fix build warning To: Jonas Karlman , Simon Glass , Philipp Tomsich Cc: Stefan Agner , u-boot@lists.denx.de References: <20230722140209.1897117-1-jonas@kwiboo.se> <20230722140209.1897117-3-jonas@kwiboo.se> Content-Language: en-US From: Kever Yang In-Reply-To: <20230722140209.1897117-3-jonas@kwiboo.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQh8fHlYZSUkaGUMZGh9OGE1VEwETFh oSFyQUDg9ZV1kYEgtZQVlOQ1VJSVVMVUpKT1lXWRYaDxIVHRRZQVlPS0hVSk5MSUpJVUpLS1VKQl kG X-HM-Tid: 0a899be53cc62ebakusnefc9b8027f X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PjI6Phw*FD1IDj4hHAIVQios SUwaFC1VSlVKTUJLTkhMTUhCTEtOVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFJTUlMNwY+ X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 2023/7/22 22:02, Jonas Karlman wrote: > Building U-Boot with CMD_INI=y result in following build warning: > > cmd/ini.c: In function 'memgets': > include/linux/kernel.h:184:24: warning: comparison of distinct pointer types lacks a cast > 184 | (void) (&_min1 == &_min2); \ > | ^~ > cmd/ini.c:92:15: note: in expansion of macro 'min' > 92 | len = min((end - *mem) + newline, num); > | ^~~ > > Fix this by adding an int cast to the pointer arithmetic result. > > Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever > --- > v3: > - No changes > > v2: > - New patch > > cmd/ini.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cmd/ini.c b/cmd/ini.c > index 81dfc4c4e83d..35de2373e602 100644 > --- a/cmd/ini.c > +++ b/cmd/ini.c > @@ -89,7 +89,7 @@ static char *memgets(char *str, int num, char **mem, size_t *memsize) > end = *mem + *memsize; > newline = 0; > } > - len = min((end - *mem) + newline, num); > + len = min((int)(end - *mem) + newline, num); > memcpy(str, *mem, len); > if (len < num) > str[len] = '\0';