public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: r8a66597: Add support for RZ/A series
Date: Wed, 29 Nov 2017 03:54:50 +0100	[thread overview]
Message-ID: <c0cad889-b5e8-79f2-eec7-40e62a5cbc0c@gmail.com> (raw)
In-Reply-To: <SG2PR06MB1165A2F91951487CBA3110D18A3A0@SG2PR06MB1165.apcprd06.prod.outlook.com>

On 11/28/2017 01:07 PM, Chris Brandt wrote:
> On Monday, November 27, 2017 1, Marek Vasut wrote:
>>> wait_for_bit() wants you to pass a direct address of a 32-bit register.
>>> The register I am waiting for is a 16-bit register and the hardware
>>> manual doesn't say 32-bit is allowed.
>>> When I do a 32-bit read on that address, I actually get a different
>>> value.
>>>
>>> For example:
>>>
>>> => md.w E8010060 1
>>> e8010060: 0040
>>> => md.l E8010060 1
>>> e8010060: 00400000
>>>
>>>
>>> So, I can't use wait_for_bit()
>>
>> Can we somehow extend wait_for_bit() ?
> 
> It's a nice function, so it would be good if it worked with more than 
> just 32-bit registers.
> 
> However, it's used in 98 places at the moment, so coordinating modifying
> all those changes at once might be an issue.

What about readb_poll_timeout() , would that work ?

> Chris
> 


-- 
Best regards,
Marek Vasut

  reply	other threads:[~2017-11-29  2:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-13 21:21 [U-Boot] [PATCH] usb: r8a66597: Add support for RZ/A series Chris Brandt
2017-11-17 19:15 ` Marek Vasut
2017-11-17 19:56   ` Chris Brandt
2017-11-18 10:24     ` Marek Vasut
2017-11-27 17:27   ` Chris Brandt
2017-11-28  3:06     ` Marek Vasut
2017-11-28 12:07       ` Chris Brandt
2017-11-29  2:54         ` Marek Vasut [this message]
2017-11-29 15:28           ` Chris Brandt
2017-11-30  0:16             ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0cad889-b5e8-79f2-eec7-40e62a5cbc0c@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox