Re: [U-Boot][PATCH v5 0/5] Improve fpga cmd usage information

[Michal Simek <michal.simek@amd.com>]

On 1/21/25 14:01, Ibai Erkiaga wrote:
> 
>    Current usage information is not read friendly specially when all the
>    options are selected. This series fix some of the issues in the info,
>    aligment and overlapping issues, excess of verbosity on the loads...
> 
>    Additionally Xilinx exclusive command dependencies are included to
>    remove text stating Xilinx Only
> 
>    The output looks like this now:
> 
>    fpga - loadable FPGA image support
> 
>    Usage:
>    fpga info   [dev]                  List known device information
>    fpga dump   <dev> <address> <size> Load device to memory buffer
>    fpga load   <dev> <address> <size> Load device from memory buffer
>    fpga loadb  <dev> <address> <size> Load device from bitstream buffer
>    fpga loadp  <dev> <address> <size> Load device from memory buffer
>                with partial bitstream
>    fpga loadbp <dev> <address> <size> Load device from bitstream buffer
>                 with partial bitstream
>    fpga loadfs <dev> <address> <size> <blocksize> <interface> [<dev[:part]>] <filename>
>                Load device from filesystem (FAT by default)
>    fpga loadmk <dev> <address>        Load device generated with mkimage
>                NOTE: loadmk operating on FIT must include subimage unit
>                name in the form of addr:<subimg_uname>
>    fpga loads  <dev> <address> <size> <authflag> <encflag> [Userkey address]
>                Load device from memory buffer with secure bistream
>                (authenticated/encrypted/both)
>                -authflag: 0 for OCM, 1 for DDR, 2 for no authentication
>                (specifies where to perform authentication)
>                -encflag: 0 for device key, 1 for user key, 2 for no encryption
>                -Userkey address: address where user key is stored
>                NOTE: secure bitstream has to be created using Xilinx bootgen tool
> 
> Changes in v5:
> - Reorder KConfig to ensure commands are listed in the same order as the
> code.
> - Clarify the bitstream file type for load/loadb/loadp/loadbp commands
> 
> Changes in v4:
> - Split 4th patch into two, one for existing symbol dependencies and one
> for the new symbol
> 
> Changes in v3:
> - Split 3rd patch into two, resorting commands and Kconfig changes
> 
> Changes in v2:
> - Tabs replaced by spaces
> - fpga command added on each option similar to other commands like sf
> - Dependencies to Xilinx only commands added in Kconfig
> 
> Ibai Erkiaga (5):
>    fpga: fix alignment on fpga cmd usage info
>    fpga: improve loads usage information
>    fpga: resort fpga commands
>    fpga: xilinx exclusive commands
>    fpga: add new symbol for fpga_loadb
> 
>   cmd/Kconfig | 35 ++++++++++++++++++------------
>   cmd/fpga.c  | 62 ++++++++++++++++++++++++-----------------------------
>   2 files changed, 49 insertions(+), 48 deletions(-)
> 

Applied.
M