From: Andrew Dyer <amdyer@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] common/cmd_mii.c bug and patch
Date: Tue, 28 Dec 2004 22:34:30 -0600 [thread overview]
Message-ID: <c166aa9f04122820342e4a5c55@mail.gmail.com> (raw)
The mii info command (the !CONFIG_TERSE_MII version)
has a bug in current cvs. If the phy address is passed
to the command the code assigns the variable addr to start,
instead of the values of addrlo which is extracted from the
command line. At that point in the code addr is always 0.
to demonstrate find a board with a phy at a non-zero address,
compare the results of 'mii info' and mii info 1' (substitute
the phy address on the test board for 1).
Also in this file on lines 55 and 418 there are two places
where a call to mii_init() is conditionally compiled in, but
one condition includes defined(CONFIG_MCF52x2) and the
other doesn't. Is this intentional?
--
Hardware, n.:
The parts of a computer system that can be kicked.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: uboot-mii-info-patch.txt
Url: http://lists.denx.de/pipermail/u-boot/attachments/20041228/1e83566e/attachment.txt
next reply other threads:[~2004-12-29 4:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-29 4:34 Andrew Dyer [this message]
2005-09-24 20:01 ` [U-Boot-Users] common/cmd_mii.c bug and patch Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c166aa9f04122820342e4a5c55@mail.gmail.com \
--to=amdyer@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox