public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andrew Dyer <amdyer@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] dbau1550 patch
Date: Wed, 29 Dec 2004 00:17:33 -0600	[thread overview]
Message-ID: <c166aa9f04122822171399a7a9@mail.gmail.com> (raw)
In-Reply-To: <1102423544.10991.26.camel@localhost>

On Tue, 07 Dec 2004 13:45:44 +0100, Leif Lindholm
<leif.lindholm@i3micro.com> wrote:
> On Mon, 2004-12-06 at 14:05 -0600, Andrew Dyer wrote:
> > A while back (Sep 23, 2004) someone named Leif posted a note about a patch
> > to add support for the AMD DbAU1550 board to u-boot here
> > https://sourceforge.net/mailarchive/forum.php?thread_id=5624545&forum_id=12898
> 
> Will send this to you privately, and later try to clean it up a bit and
> fix a few bugs this caused with the db1000 board, so Wolfgang might
> accept it into the CVS.

I've been working with your patch and expanding it a bit for stuff we wanted to
use on our custom au1550 boards.

I noticed a problem with the cpu/mips/au1x00_ether.c net driver -
it certainly causes problems for me on the au1550.

next_tx and next_rx are set to zero in the init routine - the au1550 docs 
(section 9.4.3.2 of au1550 databook) says the dmas may not start at
buffer 0 coming out of reset, so those values are not guaranteed to
be zero.  The correct value can be init'd based on the dma address
register CB field.

I changed the lines setting these up in au1x00_init() to:

        next_tx = TX_GET_DMA_BUFFER(fifo_tx[0].addr);
        next_rx = RX_GET_DMA_BUFFER(fifo_rx[0].addr);

this issue was causing me problems with rx and tx timeouts, and 
changing these values fixes my problem (at least in limited testing).
Can someone else try out this change on au1000/1100/1500
based systems?

Also, what is txbuf in au1x00_ether.c used for?  It doesn't look
like that storage ever gets used - every time through the
au1x00_send routine the buffer gets passed in from the
net code.

-- 
Hardware, n.:
        The parts of a computer system that can be kicked.

  reply	other threads:[~2004-12-29  6:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-06 20:05 [U-Boot-Users] dbau1550 patch Andrew Dyer
2004-12-07 12:45 ` Leif Lindholm
2004-12-29  6:17   ` Andrew Dyer [this message]
2004-12-29 10:44     ` Leif Lindholm
2004-12-29 10:51       ` Leif Lindholm
2005-01-05 15:28       ` Thomas Lange
2005-09-24 20:06       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c166aa9f04122822171399a7a9@mail.gmail.com \
    --to=amdyer@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox