[U-Boot-Users] fs/ext2/ext2fs.c bug and patch

[U-Boot-Users] fs/ext2/ext2fs.c bug and patch

[Andrew Dyer]

Hi all,
        In the course of getting ext2 support to work on our platform
I noticed that
the ext2load command calls ext2fs_open() and uses a return code of less than
0 as an error indication, otherwise the return value is a length.

ext2fs_open() uses 0 to indicate a returned error, so the ext2load command
doesn't properly flag errors coming back from the filesystem code.  The ext2load
command is the only caller of ext2fs_open() that I could see.

The attached patch changes the return codes from ext2fs_open() to be negative
on an error.


-- 
Hardware, n.:
        The parts of a computer system that can be kicked.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: uboot-ext2fs_open-return.txt
Url: http://lists.denx.de/pipermail/u-boot/attachments/20050108/0700e5ca/attachment.txt 

[U-Boot-Users] fs/ext2/ext2fs.c bug and patch

[Wolfgang Denk]

In message <c166aa9f050108123275ef21a4@mail.gmail.com> you wrote:
> 
> The attached patch changes the return codes from ext2fs_open() to be negative
> on an error.

Checked in, thanks.

Please provide a proper CHANGELOG entry next time.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are three ways to get something done:
        (1) Do it yourself.
        (2) Hire someone to do it for you.
        (3) Forbid your kids to do it.