public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andrew Dyer <amdyer@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [patch]fixes for cmd_fpga.c
Date: Tue, 11 Jan 2005 23:57:55 -0600	[thread overview]
Message-ID: <c166aa9f050111215735ec493f@mail.gmail.com> (raw)

The attached patch:

1) fixes a bug with the 'fpga loadb' command

The bug is in calculating the config data size - 4 bytes of length info were
being read as signed chars, casted to long, shifted and added.  The cast to
long was doing sign extension and causing an incorrect result if a byte was 
greater than 0x80.  For me this caused the fpga load to end early and time out
waiting for the hardware completion.

2) removes compilation warnings about using __FUNCTION__ concatenated with
strings

3) changes the fpga loadb to always print the file header info during a load.

I realize this patch is a mishmash - hopefully it's helpful to someone.

-- 
Hardware, n.:
        The parts of a computer system that can be kicked.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: uboot-cmdfpga-patch.txt
Url: http://lists.denx.de/pipermail/u-boot/attachments/20050111/6208c8b0/attachment.txt 

             reply	other threads:[~2005-01-12  5:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-12  5:57 Andrew Dyer [this message]
2005-08-07 22:15 ` [U-Boot-Users] [patch]fixes for cmd_fpga.c Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c166aa9f050111215735ec493f@mail.gmail.com \
    --to=amdyer@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox