public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] [patch]fixes for cmd_fpga.c
@ 2005-01-12  5:57 Andrew Dyer
  2005-08-07 22:15 ` Wolfgang Denk
  0 siblings, 1 reply; 2+ messages in thread
From: Andrew Dyer @ 2005-01-12  5:57 UTC (permalink / raw)
  To: u-boot

The attached patch:

1) fixes a bug with the 'fpga loadb' command

The bug is in calculating the config data size - 4 bytes of length info were
being read as signed chars, casted to long, shifted and added.  The cast to
long was doing sign extension and causing an incorrect result if a byte was 
greater than 0x80.  For me this caused the fpga load to end early and time out
waiting for the hardware completion.

2) removes compilation warnings about using __FUNCTION__ concatenated with
strings

3) changes the fpga loadb to always print the file header info during a load.

I realize this patch is a mishmash - hopefully it's helpful to someone.

-- 
Hardware, n.:
        The parts of a computer system that can be kicked.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: uboot-cmdfpga-patch.txt
Url: http://lists.denx.de/pipermail/u-boot/attachments/20050111/6208c8b0/attachment.txt 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [U-Boot-Users] [patch]fixes for cmd_fpga.c
  2005-01-12  5:57 [U-Boot-Users] [patch]fixes for cmd_fpga.c Andrew Dyer
@ 2005-08-07 22:15 ` Wolfgang Denk
  0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Denk @ 2005-08-07 22:15 UTC (permalink / raw)
  To: u-boot

In message <c166aa9f050111215735ec493f@mail.gmail.com> you wrote:
>
> The attached patch:
> 
> 1) fixes a bug with the 'fpga loadb' command
...
> 2) removes compilation warnings about using __FUNCTION__ concatenated with
> strings
> 
> 3) changes the fpga loadb to always print the file header info during a load.

Added, thanks.

Next time please don't forget to include a CHANGELOG entry!

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Many companies that have made themselves dependent on [the  equipment
of  a  certain  major  manufacturer] (and in doing so have sold their
soul to the devil) will collapse under the sheer weight  of  the  un-
mastered complexity of their data processing systems.
          -- Edsger W. Dijkstra, SIGPLAN Notices, Volume 17, Number 5

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-08-07 22:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-12  5:57 [U-Boot-Users] [patch]fixes for cmd_fpga.c Andrew Dyer
2005-08-07 22:15 ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox