public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] [patch] fix lib_generic version of strswab()
@ 2005-02-08 23:28 Andrew Dyer
  2005-09-25 14:15 ` Wolfgang Denk
  0 siblings, 1 reply; 2+ messages in thread
From: Andrew Dyer @ 2005-02-08 23:28 UTC (permalink / raw)
  To: u-boot

This patch changes the behavior of strswab() to end the byte swapping
when either of the two candidate bytes is null.  The old behavior was
to only abort when the second byte was null.
It looks like this is only used for little endian machines running
with CONFIG_IDE.

I noticed this because the ide serial number was not printing out -
the reason was strswab() was running past the end of the previous
string in memory and swapping a null into the first byte of my serial
number string.

-- 
Hardware, n.:
        The parts of a computer system that can be kicked.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: uboot-strswab-patch.txt
Url: http://lists.denx.de/pipermail/u-boot/attachments/20050208/b5e58a1c/attachment.txt 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [U-Boot-Users] [patch] fix lib_generic version of strswab()
  2005-02-08 23:28 [U-Boot-Users] [patch] fix lib_generic version of strswab() Andrew Dyer
@ 2005-09-25 14:15 ` Wolfgang Denk
  0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Denk @ 2005-09-25 14:15 UTC (permalink / raw)
  To: u-boot

In message <c166aa9f0502081528da149a4@mail.gmail.com> you wrote:
>
> This patch changes the behavior of strswab() to end the byte swapping
when either of the two candidate bytes is null.  The old behavior was

Added, thanks.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q: What do you get when you cross an ethernet with an income statement?
A: A local area networth.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-09-25 14:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-08 23:28 [U-Boot-Users] [patch] fix lib_generic version of strswab() Andrew Dyer
2005-09-25 14:15 ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox