[U-Boot-Users] PATCH for cmd_mem.c:do_mem_mtest()

[Andrew Dyer <amdyer@gmail.com>]

On 9/13/05, Wolfgang Denk <wd@denx.de> wrote:
> > Not on MIPS (unless someone was daft enough to map it
> > with the TLB).  The code causes a TLB store miss exception.
> > Since this is in 'common' code, I think it's a bug.
> 
> OK.
> 
> But all you need to do is #define CFG_MEMTEST_SCRATCH in  your  board
> config file, right?

Since this is common code I would suggest requiring all boards that
want to use CFG_ALT_MEMTEST be required to define CFG_MEMTEST_SCRATCH
in their config and a  #error if it's not defined.  It seems like
something likely to trip up the unaware.  Attached is a revised patch
that does this.

ChangeLog:
* Patch by Andrew Dyer, 13 September 2005:
in common/cmd_mem.c:do_mem_mtest():

Require CFG_MEMTEST_SCRATCH to be
defined if CFG_ALT_MEMTEST is enabled
instead of using the unsafe default of 0x00000000

Define CFG_MEMTEST_SCRATCH for all
targets with CFG_ALT_MEMTEST enabled.

evaluate CFG_MEMTEST_SCRATCH after
start and end are computed so CFG_MEMTEST_SCRATCH
can use those values

Update ./README

Signed-off-by: Andrew Dyer <amdyer@gmail.com>


-- 
Hardware, n.:
        The parts of a computer system that can be kicked.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: u-boot-memtest-patch2.txt
Url: http://lists.denx.de/pipermail/u-boot/attachments/20050913/636e4410/attachment.txt