From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Fri, 30 Apr 2021 09:24:13 +0200
Subject: Kirkwood: Fix tv sec/usec normalization in kwboot
In-Reply-To: <CAK7p70iO-e6GOV+G85gBDNf-85s6-=Coi-1Z2dNW8TgZbE=GyQ@mail.gmail.com>
References: <CAK7p70jMF7ShKvckopPGXeoC3BOkDJrpBrjSo-Wbe5Sfrh7y1A@mail.gmail.com>
 <16590b7c-746d-eb33-e383-5ddf596ea356@denx.de>
 <CAK7p70gX6+YAa+OcWLazD6J2R+7QOuFgWJDiQQaX3Y_jLwCm3g@mail.gmail.com>
 <646bda3c-aa50-6cb2-ea82-557272c7d871@denx.de>
 <CAK7p70iO-e6GOV+G85gBDNf-85s6-=Coi-1Z2dNW8TgZbE=GyQ@mail.gmail.com>
Message-ID: <c170f34f-d2c9-e8f6-e574-1802dc3b20b7@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 29.04.21 14:03, Dagan Martinez wrote:
>  From c200095d4136a071dd9526a48be642ce58fae8c9 Mon Sep 17 00:00:00 2001
> From: Dagan Martinez <dmartinez@starry.com>
> Date: Tue, 27 Apr 2021 15:48:31 -0400
> Subject: [PATCH v2] Kirkwood: Fix tv sec/usec normalization in kwboot
> 
> `kwboot.c` had an issue where it failed to normalize the `tv` struct in
> the case where the `tv_usec` field was 1000000, ie one second.
> 
> This caused issues on Fedora Linux 34, where `select` would return
> `EINVAL`, preventing kwboot from communicating with the board.
> 
> Signed-off-by: Dagan Martinez <dmartinez@starry.com>
> ---
> Changes for v2:
>     - Use real author name in patch

Thanks. Still this patch does not apply. How did you generate and send
it? It's somehow mangled. I suggest to use git send-email.

And another issue: The subject of this original mail still has "Re: " in
it. Please don't reply in some mail client but either use git send-email
or write a completely new message. Some mail clients tend to clutter
the whitespace etc.

Thanks,
Stefan

> 
>   tools/kwboot.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/kwboot.c b/tools/kwboot.c
> index 4be094c9c8..5d5d501d36 100644
> --- a/tools/kwboot.c
> +++ b/tools/kwboot.c
> @@ -167,7 +167,7 @@ kwboot_tty_recv(int fd, void *buf, size_t len, int timeo)
> 
>       tv.tv_sec = 0;
>       tv.tv_usec = timeo * 1000;
> -    if (tv.tv_usec > 1000000) {
> +    if (tv.tv_usec >= 1000000) {
>           tv.tv_sec += tv.tv_usec / 1000000;
>           tv.tv_usec %= 1000000;
>       }
> 


Viele Gr??e,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de