From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A36EC61DA4 for ; Mon, 13 Mar 2023 15:23:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0756B86191; Mon, 13 Mar 2023 16:23:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=seco.com header.i=@seco.com header.b="EK8tkfZu"; dkim=pass (2048-bit key) header.d=seco.com header.i=@seco.com header.b="EK8tkfZu"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CA35A86194; Mon, 13 Mar 2023 16:23:15 +0100 (CET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061b.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1b::61b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5D3C385CC6 for ; Mon, 13 Mar 2023 16:23:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seco.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hbSl14jsKtBvwlmrBn856HCq8Zn5l1eAfU/NAnyog1g=; b=EK8tkfZuaFGVfXgVGN+knuDLwv5scCofzQ6DozgA2ChAipiqWt/WA6GaY3KlyQXrmVM3tIKVO5lPiam2/Us/lX70QRER0C+dsxOtTCM3IQ9HrG68JLBV/ZK2dyVrAQToiFKyStTaPyV8aAlj3zYfWfUkoVL46maOnBB5/WGQ7FmEOM2UQZS7IJ3Qmr+hMBu5nJn/WJkacJapfzIR5QWSAWIUcM/qNn/JHkN8PM9Ijt3hEfdHZT1QkOICoaq+TpEfTP/kf644FAwOdn1lHZE9+ECFX6Vg8CyOuSmdJ/Bw6mq1e8C3dJGtA2uaer+Ju8netf/LtiZfXk2TYtids/meRQ== Received: from DB9PR05CA0001.eurprd05.prod.outlook.com (2603:10a6:10:1da::6) by PAWPR03MB9857.eurprd03.prod.outlook.com (2603:10a6:102:2ec::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.24; Mon, 13 Mar 2023 15:23:10 +0000 Received: from DB8EUR05FT032.eop-eur05.prod.protection.outlook.com (2603:10a6:10:1da:cafe::42) by DB9PR05CA0001.outlook.office365.com (2603:10a6:10:1da::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.25 via Frontend Transport; Mon, 13 Mar 2023 15:23:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 20.160.56.86) smtp.mailfrom=seco.com; dkim=pass (signature was verified) header.d=seco.com;dmarc=pass action=none header.from=seco.com; Received-SPF: Pass (protection.outlook.com: domain of seco.com designates 20.160.56.86 as permitted sender) receiver=protection.outlook.com; client-ip=20.160.56.86; helo=inpost-eu.tmcas.trendmicro.com; pr=C Received: from inpost-eu.tmcas.trendmicro.com (20.160.56.86) by DB8EUR05FT032.mail.protection.outlook.com (10.233.238.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6199.11 via Frontend Transport; Mon, 13 Mar 2023 15:23:10 +0000 Received: from outmta (unknown [192.168.82.133]) by inpost-eu.tmcas.trendmicro.com (Trend Micro CAS) with ESMTP id 112C12008088A; Mon, 13 Mar 2023 15:23:10 +0000 (UTC) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown [104.47.17.112]) by repre.tmcas.trendmicro.com (Trend Micro CAS) with ESMTPS id C5A0D2008006F; Mon, 13 Mar 2023 15:21:25 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iQGvbj7duIBm1N5H5wKsA5ewMALa58xonAOQRFqXwDUD6iSX/uqPqnZc40g0UsTzT7x0E6D1DnGFpDxgrQAX8ebXGQpp+YEwM6A0bGEnr0ArkAInnj30vakdnYAKasIVIS4XUgcqddepveApnEAK+GoW2yO2aFwae91PH4F3nr56BNfr57PxpjPVmhXdA0q5PSGY9hasbNdwqG2/b6JpmHNQT/Oi1sPS+OlLooiOtms4ik7SyyzCeJ7CYDoY8FLMLo7d5z3N9XjSv5fD0m5KqnixmgQjA3OOfsqV9XjGmM1OnldtVZLuNmjkqcYiyi/+0I4/t0ELorWYYkrkgvlERA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hbSl14jsKtBvwlmrBn856HCq8Zn5l1eAfU/NAnyog1g=; b=OUgLhqqH+kTyX+cShnYETfhYiHnUYPOd58R2uG8Pr6Y5JnTLWlDeixJHYzkGJcWexr0Vs19podv0n0vSWmaOkZ6CqMSu2M3QKTtQI+FBiphsVwUdFXQrUirXKMB1/FOX9AnDrENRr+2/ZeaChF1CKfWDwtfAh1kCih0qafuhpgPAXYoG/tSjVPXQc8+009rvzO0g4s6Cbpzfet77lqMUG5cttIKuqg6GwhV5IH8wxRZ6HCfYitTzNl+JI/2QROIKmotuUqyNInLUUh0cyOvy/wjw2TvlVzp8iYfA4iwDohaZ6PlX3p7QRrY5TpzrhxW1sXSYFqY8qd44qgW/s71dKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seco.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hbSl14jsKtBvwlmrBn856HCq8Zn5l1eAfU/NAnyog1g=; b=EK8tkfZuaFGVfXgVGN+knuDLwv5scCofzQ6DozgA2ChAipiqWt/WA6GaY3KlyQXrmVM3tIKVO5lPiam2/Us/lX70QRER0C+dsxOtTCM3IQ9HrG68JLBV/ZK2dyVrAQToiFKyStTaPyV8aAlj3zYfWfUkoVL46maOnBB5/WGQ7FmEOM2UQZS7IJ3Qmr+hMBu5nJn/WJkacJapfzIR5QWSAWIUcM/qNn/JHkN8PM9Ijt3hEfdHZT1QkOICoaq+TpEfTP/kf644FAwOdn1lHZE9+ECFX6Vg8CyOuSmdJ/Bw6mq1e8C3dJGtA2uaer+Ju8netf/LtiZfXk2TYtids/meRQ== Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=seco.com; Received: from DB9PR03MB8847.eurprd03.prod.outlook.com (2603:10a6:10:3dd::13) by AM9PR03MB7961.eurprd03.prod.outlook.com (2603:10a6:20b:438::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.24; Mon, 13 Mar 2023 15:23:06 +0000 Received: from DB9PR03MB8847.eurprd03.prod.outlook.com ([fe80::dbcf:1089:3242:614e]) by DB9PR03MB8847.eurprd03.prod.outlook.com ([fe80::dbcf:1089:3242:614e%4]) with mapi id 15.20.6178.024; Mon, 13 Mar 2023 15:23:05 +0000 Message-ID: Date: Mon, 13 Mar 2023 11:23:02 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] sysinfo: gpio: fix loop over DT "revisions" array Content-Language: en-US To: Rasmus Villemoes , u-boot@lists.denx.de Cc: Simon Glass , Tom Rini References: <20230310105803.1824795-1-rasmus.villemoes@prevas.dk> From: Sean Anderson In-Reply-To: <20230310105803.1824795-1-rasmus.villemoes@prevas.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BL1PR13CA0017.namprd13.prod.outlook.com (2603:10b6:208:256::22) To DB9PR03MB8847.eurprd03.prod.outlook.com (2603:10a6:10:3dd::13) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR03MB8847:EE_|AM9PR03MB7961:EE_|DB8EUR05FT032:EE_|PAWPR03MB9857:EE_ X-MS-Office365-Filtering-Correlation-Id: 4cb8eb53-a364-432c-d4f1-08db23d6dadb X-TrendMicro-CAS-OUT-LOOP-IDENTIFIER: 656f966764b7fb185830381c646b41a1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: gXLL/YGcSLi2NA12UT9ECDizoucrIrfi21Uw/VLwQjM00ceaAqqWp3y4f3vwgUa+1c9medoLtMqOr3AgakTk/PS3vxQYx4Asaqaq6FV03BLCWpXap61P1SZSvv3qDQAuSeVBCMcvik+Cfe/ULSIAVtZp1LhLc8GHxe6olZB18KMbRc1ym+Z2qj4Fy/BoQVDeHb6xECV9uTN4Ib1iBuypFSI7fsopmUaX+aVQNzDyUdNhPllEn5b+OL2j4bTQS+UJRWvIPD4ON9iCal0KMFoSjyqBjkFrerFudpLGPxeoMIIln8XNFC+TzS03s2CHUqHpgT7xihKH6IKUcQ/QWGC7KtVEzQe1Zsv6BowedRvQEwbO1+3sY/yLixEY41RabBuIXOrJh74CD3oluDWwZ5fhk7SGts9yF3YRYTJ828yD1bxbIR8EGwc+1FW+9QUETeIeb8CbefIi9i39AzDdxc1+Qvnp8Dxa8EJFjexSgm9GPhQNcANGvX6G+n6zpXL/VnebXypSUR2CUcr960WglOQfyGaXn3JWcLkxDmhvFxHfTLCpBOnmRD/s9gQKYhSUEA6mEMergwRDKu+C8nxHnN3Cv9vv7qDI9ebpeBv3D6UvouylHvikrvqloJtX0o4GLImu//taZy4Lp+eAMqiXjtZkoMOde1mcsLB27yyvblJLOheNnTFaYqzl3TyfhKV2E1APj+s3wU8BfYH3W3bnNLl6GTKqH6DqYkuMZKm7B2STf3slx4pl6RpfoX9rOE++Vuvm8XKI3tGIQIN1rMhRsefTvg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR03MB8847.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(39850400004)(366004)(346002)(376002)(396003)(451199018)(5660300002)(36756003)(44832011)(83380400001)(478600001)(26005)(6512007)(6506007)(52116002)(6666004)(6486002)(2616005)(53546011)(4326008)(66556008)(66946007)(8676002)(66476007)(8936002)(186003)(86362001)(31696002)(54906003)(38100700002)(38350700002)(316002)(31686004)(41300700001)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7961 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB8EUR05FT032.eop-eur05.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f9749157-f3fb-4016-083c-08db23d6d805 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: irBgIsRJFY9SOT4KPALW+wAmFJCKqQeYizNTQvuN6IxAyKZ3P7PS9XWZ9zccGZZBhH6HQn2wnfIJpkMHjUtYRjtcBrMtuflu34NDMhPbxMm3vlgUwegvfyAgnqHJAKJTKA8oLBHZKDmIoENVRovZ6NMyzatPHULhHF377Wcp2PJ3p5nQPmjYrMLltVzEe82/s+1A9wa+huRQNMyZH3q0zdiiLswPUCjjQAi7sD94/IOwT627f8LazNW2b45kOHLgVRgLZuBZ2YH8Q1q4oiZFS82v/47IaAUhwIHWWr2XnMg3F/4fQPk0OE+mGnAmv6SD042LR4aKjPkTi71oc+2hPCTrIwOVbchY0G491O26DQV8uFiCHbY5TisAKa+IQeYygNwB2RxaA7BqUqA+MKFLOg6fflPQr3zMdJUR1uNg89nWH+TxSq+VgMubhtppvMwUdUfYKHesQh1LbBD5Q4YUz47yEsymavaMT35MtUO82U/SpMahoIVlI8Qh1EEI7dkhjblueJhQmVu0bWvIghnWjYpvxYkQQ3keUz5he6x/S5RpEFSIsthWE2wfcLY1SlO4uAC+9xPyBzWdmPnCS+PVYMZQz3uzOMzRRlYDkIacrE9WmpEXM/5ZYpyNuXTcuqSsvZX+lAQoRSvKjZABopAB8z8/KVv94guRGqmx4LGrhMzOun63epEsMOX2tVnHdqZSlwFoxyVZrg9tuyj6dbIZB/EA1Y+eNkyLxnkl/XeEHnuZpiW5G60RYg3mycJvw2lx7hnHm5QDIg9w6dE3lSIOEQ== X-Forefront-Antispam-Report: CIP:20.160.56.86; CTRY:NL; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:inpost-eu.tmcas.trendmicro.com; PTR:inpost-eu.tmcas.trendmicro.com; CAT:NONE; SFS:(13230025)(136003)(39850400004)(346002)(396003)(376002)(451199018)(36840700001)(40470700004)(46966006)(5660300002)(36756003)(44832011)(40460700003)(83380400001)(47076005)(186003)(82310400005)(478600001)(6512007)(6666004)(6506007)(6486002)(2616005)(336012)(26005)(53546011)(356005)(4326008)(70206006)(8936002)(70586007)(8676002)(86362001)(31696002)(36860700001)(54906003)(316002)(34020700004)(40480700001)(82740400003)(7596003)(7636003)(31686004)(41300700001)(2906002)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 15:23:10.4089 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4cb8eb53-a364-432c-d4f1-08db23d6dadb X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bebe97c3-6438-442e-ade3-ff17aa50e733; Ip=[20.160.56.86]; Helo=[inpost-eu.tmcas.trendmicro.com] X-MS-Exchange-CrossTenant-AuthSource: DB8EUR05FT032.eop-eur05.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR03MB9857 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 3/10/23 05:58, Rasmus Villemoes wrote: > There can certainly be a lot more elements in the "revisions" (and > "names") arrays than there are gpios used to form the trinary number > we're searching for; we simply don't know the array size up-front. > > Nor do we need to, because the loop body already knows to recognize > -EOVERFLOW as "not that many elements present" (and we have a test > that specifically ensures that dev_read_u32_index() returns exactly > that). So just drop the i < priv->gpio_num condition. > > While in here, fix the weird placement of the default: keyword. > > Signed-off-by: Rasmus Villemoes > --- > drivers/sysinfo/gpio.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/sysinfo/gpio.c b/drivers/sysinfo/gpio.c > index 1d7f050998..82f90303bb 100644 > --- a/drivers/sysinfo/gpio.c > +++ b/drivers/sysinfo/gpio.c > @@ -57,7 +57,7 @@ static int sysinfo_gpio_get_str(struct udevice *dev, int id, size_t size, char * > int i, ret; > u32 revision; > > - for (i = 0; i < priv->gpio_num; i++) { > + for (i = 0; ; i++) { > ret = dev_read_u32_index(dev, "revisions", i, > &revision); > if (ret) { > @@ -80,7 +80,8 @@ static int sysinfo_gpio_get_str(struct udevice *dev, int id, size_t size, char * > strncpy(val, name, size); > val[size - 1] = '\0'; > return 0; > - } default: > + } > + default: > return -EINVAL; > }; > } Reviewed-by: Sean Anderson