From: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] serial: ns16550: add setconfig support
Date: Sat, 3 Nov 2018 08:56:14 +0100 [thread overview]
Message-ID: <c38af01a-b1ca-8a7b-5dc9-47f57c6b7fe8@gmail.com> (raw)
In-Reply-To: <CAPnjgZ2=6Ho284mZsU7RJkZB4FgaKvjgb63CX=bvfNNyYAWG6Q@mail.gmail.com>
On 03.11.2018 07:08, Simon Glass wrote:
> On 2 November 2018 at 14:28, Simon Goldschmidt
> <simon.k.r.goldschmidt@gmail.com> wrote:
>> Add possibility to update the serial parity used.
>>
>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
>> ---
>>
>> drivers/serial/ns16550.c | 43 ++++++++++++++++++++++++++++++++++++++--
>> 1 file changed, 41 insertions(+), 2 deletions(-)
>>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> Ideally we should call this from sandbox (or a test) somewhere.
Hmm, I'm a bit lost there. I haven't really used the tests so far and
grep'ing through test/ does not show any reference to ns16550 either
(where I could easily add a test).
Did you mean adding a test for this specific driver (ns16550) or for the
call to 'setconfig' in general? (Because I thought Patrice had already
done that.)
Simon
next prev parent reply other threads:[~2018-11-03 7:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 20:28 [U-Boot] [PATCH] serial: ns16550: add setconfig support Simon Goldschmidt
2018-11-03 6:08 ` Simon Glass
2018-11-03 7:56 ` Simon Goldschmidt [this message]
2018-11-16 17:04 ` Simon Goldschmidt
2018-11-16 17:09 ` Tom Rini
2018-11-16 17:12 ` Simon Goldschmidt
2018-11-16 17:24 ` Simon Glass
2018-11-16 18:28 ` Simon Goldschmidt
2018-11-07 5:39 ` Hannes Schmelzer
2018-11-17 14:08 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c38af01a-b1ca-8a7b-5dc9-47f57c6b7fe8@gmail.com \
--to=simon.k.r.goldschmidt@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox