public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] [PATCH] ARM Integrator CP flash fix
@ 2004-10-13  2:26 Shawn
  2005-01-12  0:21 ` Wolfgang Denk
  0 siblings, 1 reply; 3+ messages in thread
From: Shawn @ 2004-10-13  2:26 UTC (permalink / raw)
  To: u-boot

Hi,

Here is the patch fixing the flash support of ARM Integrator CP board.
Now it supports 28F640J3C and 28F128J3C flash chips.

Best regards,
-Shawn.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: integratorcp-flash.patch.gz
Type: application/x-gzip-compressed
Size: 4672 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20041012/14e2e3c1/attachment.bin 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot-Users] [PATCH] ARM Integrator CP flash fix
  2004-10-13  2:26 [U-Boot-Users] [PATCH] ARM Integrator CP flash fix Shawn
@ 2005-01-12  0:21 ` Wolfgang Denk
  2005-01-12  1:03   ` Shawn Jin
  0 siblings, 1 reply; 3+ messages in thread
From: Wolfgang Denk @ 2005-01-12  0:21 UTC (permalink / raw)
  To: u-boot

In message <c3d0340b041012192629f51779@mail.gmail.com> you wrote:
> 
> Here is the patch fixing the flash support of ARM Integrator CP board.
> Now it supports 28F640J3C and 28F128J3C flash chips.

Added, thanks.

But please follow the Coding Style requirements.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Mistakes are often the stepping stones to utter failure.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot-Users] [PATCH] ARM Integrator CP flash fix
  2005-01-12  0:21 ` Wolfgang Denk
@ 2005-01-12  1:03   ` Shawn Jin
  0 siblings, 0 replies; 3+ messages in thread
From: Shawn Jin @ 2005-01-12  1:03 UTC (permalink / raw)
  To: u-boot

Hi Wolfgang,

> > Here is the patch fixing the flash support of ARM Integrator CP board.
> > Now it supports 28F640J3C and 28F128J3C flash chips.
> 
> Added, thanks.

This patch had a bug in udelay(), if I remember correctly. But it's
fixed in my latest patch posted on Dec. 20. Also there are more stuff
in the latest patch I submitted.

http://sourceforge.net/mailarchive/message.php?msg_id=10359748

> But please follow the Coding Style requirements.

Would you please point out where I violated the coding style
requirements in the latest patch? I'd like to fix them and submit a
clean patch then.

Regards,
-Shawn.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-01-12  1:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-13  2:26 [U-Boot-Users] [PATCH] ARM Integrator CP flash fix Shawn
2005-01-12  0:21 ` Wolfgang Denk
2005-01-12  1:03   ` Shawn Jin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox