Re: [PATCH 1/5] arm: bcmbca: add bcm63178 SoC support

[William Zhang <william.zhang@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]

Hi Tom,

On 08/01/2022 07:02 AM, Tom Rini wrote:
> On Fri, Jul 29, 2022 at 12:48:43PM -0700, William Zhang wrote:
> 
>> BCM63178 is an ARM A7 based DSL Broadband SoC. It is part of the BCA
>> (Broadband Carrier Access origin) chipset family so it's added under
>> ARCH_BCMBCA platform. This initial support includes a bare-bone
>> implementation and dts with CPU subsystem, memory and ARM PL011 uart.
>>
>> This SoC is supported in the linux-next git repository so the dts and
>> dtsi files are copied from linux with minor fix-up that needs to be
>> upstreamed to linux as well.
>>
>> The u-boot image can be loaded from flash or network to the entry
>> point address in the memory and boot from there.
>>
>> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> [snip]
>> diff --git a/include/configs/bcm963178.h b/include/configs/bcm963178.h
>> new file mode 100644
>> index 000000000000..3ee2011b3a2d
>> --- /dev/null
>> +++ b/include/configs/bcm963178.h
>> @@ -0,0 +1,12 @@
>> +/* SPDX-License-Identifier: GPL-2.0+ */
>> +/*
>> + * (C) Copyright 2022 Broadcom Ltd.
>> + */
>> +
>> +#ifndef __BCM963178_H
>> +#define __BCM963178_H
>> +
>> +#define CONFIG_SYS_SDRAM_BASE		0x00000000
>> +#define COUNTER_FREQUENCY		50000000
>> +
>> +#endif
> 
> The one problem I have is that we need to put COUNTER_FREQUENCY
> somewhere else, if it needs to be defined.  I see the top-level README
> has outdated information about COUNTER_FREQUENCY, which is most often
> CONFIG_COUNTER_FREQUENCY instead, as well.
> 
Sure I will move it to CONFIG_COUNTER_FREQUENCY in soc defconfig.

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]