From: Roger Quadros <rogerq@kernel.org>
To: Maxime Ripard <mripard@kernel.org>,
Simon Glass <sjg@chromium.org>,
Joe Hershberger <joe.hershberger@ni.com>,
Ramon Fried <rfried.dev@gmail.com>, Nishanth Menon <nm@ti.com>,
Ravi Gunasekaran <r-gunasekaran@ti.com>
Cc: Javier Martinez Canillas <javierm@redhat.com>,
Peter Robinson <pbrobinson@gmail.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH 4/4] fixup! arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1
Date: Thu, 20 Jul 2023 18:27:56 +0300 [thread overview]
Message-ID: <c478ac2a-33dc-e15a-b69e-104451d26e29@kernel.org> (raw)
In-Reply-To: <20230720-ti-mdio-pinmux-v1-4-0bd3bd1cf759@kernel.org>
On 20/07/2023 12:55, Maxime Ripard wrote:
> Dropping ranges entirely doesn't work since the register offset on the
> MDIO device node will now be completely off, so we need to adjust it to
> the right value without the translation.
>
> We also need to have an empty ranges property for the reg address to be
> properly evaluated.
>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
> ---
> arch/arm/dts/k3-am625-sk-u-boot.dtsi | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/dts/k3-am625-sk-u-boot.dtsi b/arch/arm/dts/k3-am625-sk-u-boot.dtsi
> index fe1c7408a89d..2ec3fff99f32 100644
> --- a/arch/arm/dts/k3-am625-sk-u-boot.dtsi
> +++ b/arch/arm/dts/k3-am625-sk-u-boot.dtsi
> @@ -122,8 +122,8 @@
> reg = <0x0 0x8000000 0x0 0x200000>,
> <0x0 0x43000200 0x0 0x8>;
> reg-names = "cpsw_nuss", "mac_efuse";
> - /delete-property/ ranges;
> bootph-pre-ram;
> + ranges;
>
> cpsw-phy-sel@04044 {
> compatible = "ti,am64-phy-gmii-sel";
> @@ -132,6 +132,10 @@
> };
> };
>
> +&cpsw3g_mdio {
> + reg = <0x0 0x8000f00 0x0 0x100>;
> +};
> +
Why this change?
Linux DT has
cpsw3g_mdio: mdio@f00 {
compatible = "ti,cpsw-mdio","ti,davinci_mdio";
reg = <0x00 0xf00 0x00 0x100>;
And it is a child of cpsw3g node.
> &cpsw_port1 {
> bootph-pre-ram;
> };
>
--
cheers,
-roger
next prev parent reply other threads:[~2023-07-20 15:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 9:55 [PATCH 0/4] net: ti: am65-cpsw-nuss: Fix DT binding handling of pinctrl Maxime Ripard
2023-07-20 9:55 ` [PATCH 1/4] pinctrl: Create a select_state variant with the ofnode Maxime Ripard
2023-07-20 15:56 ` Roger Quadros
2023-07-20 9:55 ` [PATCH 2/4] net: ti: am65-cpsw-nuss: Enforce pinctrl state on the MDIO child node Maxime Ripard
2023-07-20 15:47 ` Roger Quadros
2023-07-21 12:17 ` Maxime Ripard
2023-07-20 9:55 ` [PATCH 3/4] fixup! arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1 Maxime Ripard
2023-07-20 9:55 ` [PATCH 4/4] " Maxime Ripard
2023-07-20 15:27 ` Roger Quadros [this message]
2023-07-21 7:46 ` Maxime Ripard
2023-07-21 9:14 ` Roger Quadros
2023-07-21 9:23 ` Maxime Ripard
2023-07-20 13:33 ` [PATCH 0/4] net: ti: am65-cpsw-nuss: Fix DT binding handling of pinctrl Ravi Gunasekaran
2023-07-20 13:56 ` Roger Quadros
2023-07-20 14:00 ` Nishanth Menon
2023-07-20 14:12 ` Maxime Ripard
2023-07-20 14:41 ` Roger Quadros
2023-07-20 14:52 ` Nishanth Menon
2023-07-26 9:14 ` Ravi Gunasekaran
2023-07-26 12:49 ` Maxime Ripard
2023-07-27 5:27 ` Ravi Gunasekaran
2023-07-26 12:52 ` Nishanth Menon
2023-07-27 5:36 ` Ravi Gunasekaran
2023-07-27 7:10 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c478ac2a-33dc-e15a-b69e-104451d26e29@kernel.org \
--to=rogerq@kernel.org \
--cc=javierm@redhat.com \
--cc=joe.hershberger@ni.com \
--cc=mripard@kernel.org \
--cc=nm@ti.com \
--cc=pbrobinson@gmail.com \
--cc=r-gunasekaran@ti.com \
--cc=rfried.dev@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox