From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CDCAC43334 for ; Mon, 27 Jun 2022 11:39:11 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A9F5883FF8; Mon, 27 Jun 2022 13:39:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1656329948; bh=YYvzBqP+S9ndILfV5mtiCl6xV2UCHKVUC/oWj8+Grr4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ZJ84zf+N/555uP1lyDMfErF71uwKKZNvsrzjetUe1UvZu/7itjQIpCDDpCfBSRpWD HOgNl9jM+3WgJ8gQIYh1mU8Fw2emcufz/zq+9iPP5mYQGYPqPwpr7GRYYOSjecSYmb uUlMWcVQIAaYRj/UN4sXBEFuYgEtzFX1HGND3vKjXjFtsLMg4f0A/n6uQQzze+usZg Nv8LCgl1JXsr1KQ2j5ol+2Rgl3EcU+hBnl1idQtNZmo0TZYpUmPD3B45KXUClFOY4o sIIeZFXRLK4IEKd2wvogURC0OzyElNiAwU4olgvLhdbVZtayKkTcEFbH3faeLGpuld iHKUNSwFkBOIw== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 2D61C83E63; Mon, 27 Jun 2022 13:39:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1656329944; bh=YYvzBqP+S9ndILfV5mtiCl6xV2UCHKVUC/oWj8+Grr4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=XQpF0+AEaJJ028I+hLBhikhI6nMMu1zjCSAO1Yv+PI5JcEmcXsHfADdE80VDoMqD8 k6gY1VGSUAuPWowP3SoOLCNNF95FIVZGciSwZQMv9VLyO25MSzGUySJHvecSEeKAok tKS2iaHVFeeA/phoMVlvf4nk8HT4GMmiHICLHSA6EoW4fKpek7GlC4sA2vasmkhkLj ywTVvge34OUVc7zECVhjSrE3mczsuOHLDAO1aE2dRQ3GSEPccBeV05tdExaUJ5ce9m 8JBxD/o8+y3JLuElwhgDd0caskzRM4pntMXoPE9GPf4/uPRDdjTyTJ5DNQfad6ObTT msQSRsdKzDYTQ== Message-ID: Date: Mon, 27 Jun 2022 13:39:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] usb: kbd: allow probing even if usbkbd not in stdin Content-Language: en-US To: =?UTF-8?Q?K=c3=b6ry_Maincent?= Cc: u-boot@lists.denx.de, thomas.petazzoni@bootlin.com References: <20220622085931.1205590-1-kory.maincent@bootlin.com> <0ac21e40-3295-4dbd-22b3-253846b98a47@denx.de> <20220627120332.23bd6bcf@kmaincent-XPS-13-7390> From: Marek Vasut In-Reply-To: <20220627120332.23bd6bcf@kmaincent-XPS-13-7390> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 6/27/22 12:03, Köry Maincent wrote: > Hello Marek, > > On Fri, 24 Jun 2022 20:12:31 +0200 > Marek Vasut wrote: > >> On 6/22/22 10:59, kory.maincent@bootlin.com wrote: >>> From: Kory Maincent >>> >>> For now the driver does not probe if usbkbd was not present in stdin. >>> This presents two issues, we can not probe the driver before setting stdin >> >> Environment should be up and running before USB, so this is likely not a >> problem. > > Having a driver probing only in this specific state is weird? > It should probe whatever the state of stdin. > >> >>> and we can not use this driver in other manner than stdin console. >>> >>> This patch fixes this by adding an else statement. It simply probes the >>> driver without console management in the case "usbkbd" is not in stdin. >> >> Can you document the usecase in a bit more detail ? > > My usecase is to get a key press from the USB keyboard and do some thing about > it in board_init. I do not want to multiplex the keyboard input to stdin but I > still want to read character from it. All right, understood, both. Thanks for clarification. I applied this to usb/next , I hope that's OK ?