From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Sat, 5 Aug 2017 21:23:37 +0200
Subject: [U-Boot] [PATCH 1/5] mmc: uniphier-sd: Factor out register IO
In-Reply-To: <CAK7LNARFOR82V=JOtgPuDAz2Bs329AHD44jdwxk8spxtYp5USA@mail.gmail.com>
References: <20170721212436.26073-1-marek.vasut+renesas@gmail.com>
 <CAK7LNARFOR82V=JOtgPuDAz2Bs329AHD44jdwxk8spxtYp5USA@mail.gmail.com>
Message-ID: <c6861e97-649a-5615-aa91-ea4d6af6a5d6@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 08/03/2017 02:36 PM, Masahiro Yamada wrote:
> Hi Marek,

Hi,

[...]

>> +static u32 uniphier_sd_readl(struct uniphier_sd_priv *priv, const u32 reg)
> 
> "const" is unneeded here.

Why? The function should not modify reg , so it is const.

> Also, could you use "unsigned int" or "int" for reg?

Why?

>> +{
>> +       return readl(priv->regbase + reg);
>> +}
>> +
>> +static void uniphier_sd_writel(struct uniphier_sd_priv *priv,
>> +                              const u32 val, const u32 reg)
> 
> Same here.  Please drop "const".
> 
> Please use "unsigned int" or "int" for reg
> 
> It is OK to use u32 for val.
> 
> 
> 
> 


-- 
Best regards,
Marek Vasut