From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42F9FC38142 for ; Tue, 31 Jan 2023 12:51:54 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2F3808561C; Tue, 31 Jan 2023 13:51:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="fX9lWfO6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A3834802B4; Tue, 31 Jan 2023 13:51:44 +0100 (CET) Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 159A4802B4 for ; Tue, 31 Jan 2023 13:51:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@gmail.com Received: by mail-pl1-x629.google.com with SMTP id b5so7695819plz.5 for ; Tue, 31 Jan 2023 04:51:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=doKUElGMUf60P2KQQcpYwMWn+3tkqVbDiyb6JgEqXPU=; b=fX9lWfO6+Y+XxR2FpGzhDA7+Yj6p2Es5yMNElT09XMlHaARFN5Z3DkIhghyy4nxjhL F/EzXl75bza0fNaWVhdMu4XaFWeWezCUVRxNRSuXoLV7uMU3RuDYGwQd9u42AyM1uhNM yIVP7fcxS6bd/NnR1nrCymA/QnsDMjW/CAmAMCOj1Iq6J0vtWmX+EJN3T6eEFV5ETq0B /Eo5gvYNv1HGBgsWCfZNT5n6zS3mzB3nvIZ8zyfNMuvEZ4ciucUZHUCsIMQndkKydcnZ Edo7upHv7L2Tx4LZ6ghfiLVy5utJwm6bcitOOiQFiMOhX9/b3YlDASqqkyvHnrFxEaWY 2dPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=doKUElGMUf60P2KQQcpYwMWn+3tkqVbDiyb6JgEqXPU=; b=WnDQQKE9bYyF7mledrf3WHwCNS/LD0EemlfFGQ3lh811i1Hc3Mw80XjrntgbX4SPwd f3P5UM7Ymn4J6E50/7RRffdrhbuEiUsXJQ0x/V2HFMGQR7njyyfIEDoKWZXi5atxmfqc oeZlHzHk8GUv77B/RD7xz8yuEJt1CK204W5pH2WajOuzzgh3lH+XLDoJDYVss5UkaU7n 4PawFuSLamOI9GMEmIFpKjM+aFsodEb17+2iN1YmCJ3+PlEvPhvYbTRqyHRwZLe5i6XV h5wOkQ97h+puU1ghzb5573ktfQGtIMTOkURfXp6jOzPDNdmTfcFZYupu64kM3WUg5yv0 pMEA== X-Gm-Message-State: AO0yUKXunhHyYTThzRwQZvDWTL750ZI1uyha5Mp7el+OkvV5NYyMfx+L VK86DaZzjCSf6DiQBhSV/nqco1qj9oejdw== X-Google-Smtp-Source: AK7set9SLxgtBeGFbCoLTFC530/6ChOEloP8RAUjtHKBbeeHe1zqr4Bdbo2qfbAsBAJYj0NowWZSIQ== X-Received: by 2002:a05:6a20:12d1:b0:bc:b9d2:f0f8 with SMTP id v17-20020a056a2012d100b000bcb9d2f0f8mr12247776pzg.24.1675169482273; Tue, 31 Jan 2023 04:51:22 -0800 (PST) Received: from [192.168.0.19] ([183.99.112.216]) by smtp.gmail.com with ESMTPSA id f190-20020a636ac7000000b004a737a6e62fsm8311015pgc.14.2023.01.31.04.51.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 04:51:21 -0800 (PST) Message-ID: Date: Tue, 31 Jan 2023 21:51:19 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 05/88] power: Drop pmic_max77693.c Content-Language: en-US To: Simon Glass , u-boot@lists.denx.de Cc: Tom Rini , Jaehoon Chung References: <20230123220031.3540724-1-sjg@chromium.org> <20230123220031.3540724-6-sjg@chromium.org> From: Jaehoon Chung In-Reply-To: <20230123220031.3540724-6-sjg@chromium.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 1/24/23 06:59, Simon Glass wrote: > Drop this driver and the associated CONFIG option, as it is not used. > > Signed-off-by: Simon Glass Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > drivers/power/mfd/Makefile | 1 - > drivers/power/mfd/pmic_max77693.c | 96 ------------------------------- > 2 files changed, 97 deletions(-) > delete mode 100644 drivers/power/mfd/pmic_max77693.c > > diff --git a/drivers/power/mfd/Makefile b/drivers/power/mfd/Makefile > index 5dfbdbd1b0f..b5ec8f00bb0 100644 > --- a/drivers/power/mfd/Makefile > +++ b/drivers/power/mfd/Makefile > @@ -3,5 +3,4 @@ > # Copyright (C) 2013 Samsung Electronics > # Piotr Wilczek > > -obj-$(CONFIG_POWER_PMIC_MAX77693) += pmic_max77693.o > obj-$(CONFIG_POWER_MUIC_MAX77693) += muic_max77693.o > diff --git a/drivers/power/mfd/pmic_max77693.c b/drivers/power/mfd/pmic_max77693.c > deleted file mode 100644 > index e32a9722a40..00000000000 > --- a/drivers/power/mfd/pmic_max77693.c > +++ /dev/null > @@ -1,96 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0+ > -/* > - * Copyright (C) 2013 Samsung Electronics > - * Piotr Wilczek > - */ > - > -#include > -#include > -#include > -#include > -#include > -#include > - > -static int max77693_charger_state(struct pmic *p, int state, int current) > -{ > - unsigned int val; > - > - if (pmic_probe(p)) > - return -ENODEV; > - > - /* unlock write capability */ > - val = MAX77693_CHG_UNLOCK; > - pmic_reg_write(p, MAX77693_CHG_CNFG_06, val); > - > - if (state == PMIC_CHARGER_DISABLE) { > - puts("Disable the charger.\n"); > - pmic_reg_read(p, MAX77693_CHG_CNFG_00, &val); > - val &= ~0x01; > - pmic_reg_write(p, MAX77693_CHG_CNFG_00, val); > - return -ENOTSUPP; > - } > - > - if (current < CHARGER_MIN_CURRENT || current > CHARGER_MAX_CURRENT) { > - printf("%s: Wrong charge current: %d [mA]\n", > - __func__, current); > - return -EINVAL; > - } > - > - /* set charging current */ > - pmic_reg_read(p, MAX77693_CHG_CNFG_02, &val); > - val &= ~MAX77693_CHG_CC; > - val |= current * 10 / 333; /* 0.1A/3 steps */ > - pmic_reg_write(p, MAX77693_CHG_CNFG_02, val); > - > - /* enable charging */ > - val = MAX77693_CHG_MODE_ON; > - pmic_reg_write(p, MAX77693_CHG_CNFG_00, val); > - > - /* check charging current */ > - pmic_reg_read(p, MAX77693_CHG_CNFG_02, &val); > - val &= 0x3f; > - printf("Enable the charger @ %d [mA]\n", val * 333 / 10); > - > - return 0; > -} > - > -static int max77693_charger_bat_present(struct pmic *p) > -{ > - unsigned int val; > - > - if (pmic_probe(p)) > - return -ENODEV; > - > - pmic_reg_read(p, MAX77693_CHG_INT_OK, &val); > - > - return !(val & MAX77693_CHG_DETBAT); > -} > - > -static struct power_chrg power_chrg_pmic_ops = { > - .chrg_bat_present = max77693_charger_bat_present, > - .chrg_state = max77693_charger_state, > -}; > - > -int pmic_init_max77693(unsigned char bus) > -{ > - static const char name[] = "MAX77693_PMIC"; > - struct pmic *p = pmic_alloc(); > - > - if (!p) { > - printf("%s: POWER allocation error!\n", __func__); > - return -ENOMEM; > - } > - > - debug("Board PMIC init\n"); > - > - p->name = name; > - p->interface = PMIC_I2C; > - p->number_of_regs = PMIC_NUM_OF_REGS; > - p->hw.i2c.addr = MAX77693_PMIC_I2C_ADDR; > - p->hw.i2c.tx_num = 1; > - p->bus = bus; > - > - p->chrg = &power_chrg_pmic_ops; > - > - return 0; > -}